`oneof` generated class does not contain `enum` types

Hi, I was playing with oneof keyword and found out that the generated class seems not following the doc. on https://developers.google.com/protocol-buffers/docs/reference/java-generated#oneof . For example, if i have the follow in .proto:

message Message{
    oneof payload{
        int32 foo_int =4;
        string foo_string =9;
    }
}

it generates something like:

  @WireField(
      tag = 4,
      adapter = "com.squareup.wire.ProtoAdapter#INT32"
  )
  public final Integer foo_int;

  @WireField(
      tag = 9,
      adapter = "com.squareup.wire.ProtoAdapter#STRING"
  )
  public final String foo_string;

but not the enum types as I expected;

And with that, it seems the only way I can know what “type” of my payload is checking foo_int and foo_string to see which one is not null. But what about if I want have adding more types in oneof block, is there a quicker way to know the “type” of my payload?

Thanks in advance

[swankjesse]

I’m looking at this API and I don’t see the improvement. Presumably this is where you’re starting from:

  if (message.foo_int != null) {
    doIntThings(message.foo_int);
  } else if (message.foo_string != null) {
    doStringthings(message.foo_string);
  } else {
    doNothing();
  }

The proposed API gets you here:

  Payload<?> payload = message.payload;
  if (payload.type == Integer.class) {
    doIntThings((Integer) payload.field);
  } else if (payload.type == String.class) {
    doStringthings((String) payload.field.);
  } else {
    doNothing();
  }

I think the closest we get with oneof that’s an improvement is a visitor, and it’s not really much better.

[alecmuffett]

Hello All - I just found this, am wondering if there has been any change, since?