question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Lunr Languages JavaScript files missing .min.js extension

See original GitHub issue

Description

The Lunr Languages JavaScript files are minified in mkdocs-material, but the file extension does not indicate this.

This causes problems when packaging for Debian, as the package checker expects the .min.js file extension to appear on minified source files.

Expected behaviour

The file extension on all Lunr Languages JavaScript files should be <filename>.min.js. (The files are also missing their copyright attribution, which is present upstream.)

Package versions

Material: 4.4.2

Issue Analytics

  • State:closed
  • Created 4 years ago
  • Comments:7 (4 by maintainers)

github_iconTop GitHub Comments

1reaction
hughmcmastercommented, Sep 16, 2019

I don’t know how you tested it, but without updating the HTML which includes the files which extensions you changed it cannot possibly work. Maybe the search still works, but the stemmers should have failed to be loaded with a 404.

I’ve just checked again. And yes, the stemmers did fail to load. I pushed the wrong branch.

Have you seen how many issues are opened for this project regarding seemingly trivial stuff from users that don’t really know what they’re doing? I can’t say I’ve followed things that closely. But you are incredibly responsive and patient.

I understand that this might be important for you, but I see no point issuing a major release for something that has literally zero upside for the UX or DX.

I didn’t ask you to make this a priority or a major release, nor did I expect you to. I’d like to see it happen at some point, but if you really don’t want to, I’ll accept that.

0reactions
hughmcmastercommented, Dec 4, 2019

Thank you!

Read more comments on GitHub >

github_iconTop Results From Across the Web

Language Support - Lunr.js
Lunr has full support for the indexing and searching of documents in English. If your documents are in another language, you need to...
Read more >
Automatic Documentation For JavaScript Projects
Documentation.js ... This library is in a way closely related to jsdoc-to-markdown (used in the setup of many other strategies below) in that...
Read more >
lunr-languages-zh - npm Package Health Analysis - Snyk
A a collection of languages stemmers and stopwords for Lunr Javascript library (with Chinese support by @repairearth) For more information ...
Read more >
Configuration - MkDocs
Project settings are configured by default using a YAML configuration file in the project directory named mkdocs.yml . You can specify another path...
Read more >
How to upgrade - Material for MkDocs - GitHub Pages
If you've used theme extension to override a block or template, make sure that it ... + "search": "assets/javascripts/workers/search.217ffd95.min.js" | url, ...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found