Proposal for Hypothesis integration

I’m interested in creating an extension that is quite similar to Disqus. The result will be the same, i.e. the integration of a discussion/annotation tool, except it’s not Disqus but Hypothes.is. Here’s a link to how this gets integrated manually.

From what I’ve seen by looking at the code for Disqus it’s really quite similar, it comes down to including an embed.js and configuring the behaviour via some options.

My questions are:

1. Would you accept an integration like this as a PR?
2. Are there any other places in the code to modify in order make such an integration work?

Thanks.

Edit: regarding question 2, there is of course the base.html file that would need an update, too.

[jfix]

I kind of agree with your assessment of the Hypothesis functionality on mobile (and so, it seems, do the project people) but there is not much I can do. On Slack in a conversation they said:

We agree that the mobile experience for Hypothesis needs work. We just brought on a frontend designer + developer who will be able to help us tackle this going forward.

That was 11 months ago and surely priorities do change … Personally, I think that on a small screen you have to make trade-offs of what you can do and display, and not showing annotations would for me and our use cases be an acceptable trade-off. We’ll do some tests with tablet screen sizes, but I expect it’s possible to show the sidebar in both landscape and portrait mode.

I didn’t know about the extrahead template variable and the extra_javascript option, so I guess we will experiment with these for the time being. Thanks!

[jfix]

Added above comment to an existing ticket: https://github.com/hypothesis/product-backlog/issues/94#issuecomment-507346194