Remove propTypes
See original GitHub issueIs your feature request related to a problem? Please describe.
I am currently trying to run the library on react-native-web
. I know that the library is not officially supported on web, but would be nice to make it work. I will be doing some changes on my own fork, but wanted to use this thread as a platform to discuss a few things.
react-native-web
has unspoorted ViewPropTypes
as of 0.12. Therefore, I get the following error:
Popover.tsx?f681:1 Uncaught TypeError: Cannot read property 'style' of undefined
Caused by the following lines:
popoverStyle: ViewPropTypes.style,
arrowStyle: ViewPropTypes.style,
backgroundStyle: ViewPropTypes.style,
Describe the solution you’d like
First I want to ask you why is PropTypes
used in this repo while there is already great TypeScript implementation. If we get rid of PropTypes, it will work on react-native-web
too. I will work on further improvements to make this library work on web, but I think it would be the first step.
I would be happy if you could inform me why you choose to opt in for PropTypes.
Thanks in advance!
Issue Analytics
- State:
- Created 3 years ago
- Comments:12 (6 by maintainers)
Top GitHub Comments
Ah very cool, I’ll add this in and see if it works
Ok, this is done in the latest release, thanks for finding a good solution!