TransactionEnvelope & TransactionResult fromXRP methods throw error on blockchain data

Describe the bug Greetings! Block Trac uses the stellar-sdk to subscribe to validated blocks and import transactions. When processing a recent block (38115807 @ 2021-11-03 15:00:15 UTC), we came across transaction ec6e4745f0ac7d7536dd4cebdd65a5c4ac7837e71aff2034cb52775ae7aaab9c which results in an error when parsed (see below)

What version are you on? 9.0.1

To Reproduce Run the following test script:

const StellarSdk = require('stellar-sdk')

var sdk = new StellarSdk.Server('https://horizon.stellar.org');

var transaction =
  sdk.transactions()
     .transaction("ec6e4745f0ac7d7536dd4cebdd65a5c4ac7837e71aff2034cb52775ae7aaab9c")
     .call()
     .then(function(tx){
       console.log(tx.hash);
       //console.log(JSON.stringify(tx, null, 2));
       console.log(StellarSdk.xdr.TransactionEnvelope.fromXDR(tx.envelope_xdr));
       console.log(StellarSdk.xdr.TransactionResult.fromXDR(tx.result_xdr));

     }).catch(function(e){
       console.log(e)
     });

To see the following output:

ec6e4745f0ac7d7536dd4cebdd65a5c4ac7837e71aff2034cb52775ae7aaab9c
Error: XDR Read Error: Unknown EnvelopeType member for value 1094795585
    at Function.read (/home/mmorsi/Workspace/exp/node_modules/js-xdr/lib/enum.js:46:15)
    at Function.read (/home/mmorsi/Workspace/exp/node_modules/js-xdr/lib/union.js:111:36)
    at Function.fromXDR (/home/mmorsi/Workspace/exp/node_modules/js-xdr/lib/io-mixin.js:51:23)
    at /home/mmorsi/Workspace/exp/ss.js:12:55
    at processTicksAndRejections (internal/process/task_queues.js:95:5)

If TransactionEnvelope.fromXDR is commented above, the following error is produced:

ec6e4745f0ac7d7536dd4cebdd65a5c4ac7837e71aff2034cb52775ae7aaab9c
Error: XDR Read Error: Unknown TransactionResultCode member for value 1111048513
    at Function.read (/home/mmorsi/Workspace/exp/node_modules/js-xdr/lib/enum.js:46:15)
    at Function.read (/home/mmorsi/Workspace/exp/node_modules/js-xdr/lib/union.js:111:36)
    at /home/mmorsi/Workspace/exp/node_modules/js-xdr/lib/struct.js:57:26
    at arrayMap (/home/mmorsi/Workspace/exp/node_modules/lodash/_arrayMap.js:16:21)
    at map (/home/mmorsi/Workspace/exp/node_modules/lodash/map.js:50:10)
    at Function.read (/home/mmorsi/Workspace/exp/node_modules/js-xdr/lib/struct.js:52:38)
    at Function.fromXDR (/home/mmorsi/Workspace/exp/node_modules/js-xdr/lib/io-mixin.js:51:23)
    at /home/mmorsi/Workspace/exp/ss.js:13:53
    at processTicksAndRejections (internal/process/task_queues.js:95:5)

Expected behavior The XDR should be successfully parsed and no error produced.

Additional context N/A. Thank you for the great library.

[movitto]

👍 thanks @Shaptic it worked. Funny, we were having trouble yesterday parsing the XDR (passing the encoding in) but everything is back working. Chalk it up to a fluke, I apologize for the noise. Thanks again!

[Shaptic]

Hah, got it. You need to pass the encoding type to fromXDR, which defaults to "raw". If you pass "base64", it will work! You can also use the helper StellarSdk.TransactionBuilder.fromXDR(tx.envelope_xdr, StellarSdk.Networks.PUBLIC) which will give you a nicer structure to work with (i.e. a StellarSdk.Transaction instance rather than a raw StellarSdk.xdr.Transaction).