Only Application Scope

I’m newbie in DI, and decide to start learning it with toothpick. I try to refactor my sample application and add DI. My data repository is application singleton. Then I use it inside fragment, I inject it in fragment’s onCreate:

public class MyFragment extends BaseFragment {
    ........
    @Inject
    MyRepository repository;
    .........

    @Override
    public void onCreate(@Nullable Bundle savedInstanceState) {
        Toothpick.inject(this, ((App)getActivity().getApplication()).getAppScope());
        super.onCreate(savedInstanceState);
    }

App.java

public class App extends Application {
    private Scope appScope;
    @Override
    public void onCreate() {
        super.onCreate();
        initToothpick();
    }

    private void initToothpick() {
        appScope = Toothpick.openScope(this);
        appScope.installModules(new SmoothieApplicationModule(this, Preference.NAME), new MyApplicationModule());
        Toothpick.inject(this, appScope);
    }

    public Scope getAppScope() {
        return appScope;
    }
}

Is it fine?

[stephanenicolas]

You don’t have a fragment scope, you use the activity scope in the fragment. Which is what you have to do, and the activity closes it properly already.

I close the issue. Please use stack overflow for any new question. feel free to ping us here if no one answers.

[pdapnz]

Thank you, I refactored scopes as you recommends.

public class BaseViewModel extends AndroidViewModel {

    private Scope scope;

    public BaseViewModel(Application application) {
        super(application);
        scope = Toothpick.openScopes(application, this);
        scope.installModules(new ViewModelModule());
        Toothpick.inject(this, scope);
    }
    ...........

    @Override
    protected void onCleared() {
        super.onCleared();
        Toothpick.closeScope(scope);
    }
}

public class MainActivity extends BaseActivity {

    @Override
    protected void onCreate(Bundle savedInstanceState) {
        Scope scope = Toothpick.openScopes(getApplication(), this);
        scope.installModules(new ActivityModule());
        super.onCreate(savedInstanceState);
        Toothpick.inject(this, scope);
   ......

    @Override
    public void onDestroy() {
        Toothpick.closeScope(this);
        super.onDestroy();
    }
}

As I understand Activity and ViewModel now fine. App and activity used as scopes and scopes is closing. ViewModel has own scope independent of activity.

But should I close fragment scope? Now it is something like this:

public class BaseFragment extends LifecycleFragment {

    @Override
    public void onCreate(@Nullable Bundle savedInstanceState) {
        Scope scope = Toothpick.openScopes(getActivity().getApplication(), getActivity());
        scope.installModules(new FragmentModule());
        super.onCreate(savedInstanceState);
        Toothpick.inject(this, scope);
    }

}