Move custom buttons automatically to the sidebar
See original GitHub issueWe have several custom buttons implemented.
We’ve noticed that the provided button components, usually hide in the sidebar.
That was no issue for us, until we decided we’re going to make our website into a hybrid app, and we have enabled several features, plus our custom buttons.
The real problem arrises when we try to resize the content - custom buttons are not going into the sidebar.
We are managing to hide them via hacks, or just some css tricks but every time we want to add an additional button, it becomes a struggle and we are having issues with different screen sizes and devices.
We would like to suggest you to build in functionality that allows creation of custom buttons as components.
For Example:
<pdf-custom-button [icon]="'icon'" [label]="'My label'" (click)="callmyfunc" [styleClass]="'myStyle'" [tooltip]="'Text on hover'"> </pdf-custom-button>
Issue Analytics
- State:
- Created 10 months ago
- Reactions:1
- Comments:5 (3 by maintainers)
Top GitHub Comments
That’s a really nice idea! Loving it!
Just to make sure we’re talking about the same thing: I assume your sidebar is what I call the secondary menu - the kebab menu on the right-hand side?
As for the
<pdf-custom-button>
: Sound’s great, but I guess I’ll have to wrap my head around the idea. It feels right, but at the moment, I don’t know to implement it. Maybe I’ll reach out to you again with questions. One thing to consider is the CSS breakpoints. Currently, I’ve defined three or four screen sizes, and I’d like to enable you to define which button is shifted to the secondary menu on which screen size. I’m not sure if you need this feature, but I guess there are developers out there who need it.Counting and measuring buttons sounds like the way to go. It’d allow me to get rid of the CSS magic while offering developers a lot more flexibility. Truth to tell, I was never happy with the breakpoint approach. It works, but it’s a far cry from the elegance of the concept of breakpoinst of Bootstrap, Material Design or Tailwind.
If I find a way to provide decent backward compatibility, that’s going to be a cool feature for version 16!