Seemingly conflicting how-to-build.md Instructions
See original GitHub issueI have been attempting to build the ngx-extended-pdf-viewer library from scratch, so as to incorporate a slightly-modified pdf.js. The provided walkthrough, however, seems to conflict with both itself and the updateMozillasPdfViewer.sh/.bat scripts.
Steps 2-11 involve building pdf.js
in an embedded-pdf
folder, although navigation in steps 12-14 assume pdf.js
was not nested within any folder.
Step 14’s update scripts refer to a mypdf.js
directory for the pdf.js
build, despite the build instructions referring to mozillas-pdf.js
.
In an attempt to avoid these issues, I place the cloned pdf.js
repo in the same directory as this repo, and rename it to mypdf.js
. The updateMozillasPdfViewer.bat
script and npm run win-package
then run without any explicit errors.
Unfortunately, ng serve
results in a “properly” compiled Angular project which fails to display anything due to unreachable resources (404s for runtime.js, pollyfills.js, styles.js (those don’t exist within src to begin with, perhaps a package.json issue?)).
Any advice on how to build from source? Have I unintentionally been going about this all wrong? Thank you in advance!
Issue Analytics
- State:
- Created 3 years ago
- Comments:6 (3 by maintainers)
Sorry for the delay with finalizing testing! Runs without any issues, from my standpoint!
Thanks for the quick response! It turns out that, for the end result issue, I simply had to point the
<base href...>
inindex.html
to the root directory;ng serve
seems to work fine then, though I’ll have to see if this creates any other problems. Otherwise, it appears both your Windows and Unix build scripts work well. Thanks again!