Code cleaning/refactoring

I’m looking through stingray’s code and I saw some things I think we should avoid.

utils.py has 2 private methods which are used in io.py file Not all imports are at the top of file Sometimes between operators are spaces sometimes not: 1+2 vs 1 + 2 (I prefer second version)

I know that issues like that are not really important, but might be copied bu other contributors and more time consumed as a huge “problems”

Let me know if it should be “fixed” I will try to do it.

[dhuppenkothen]

@TomaszKolek: I think the reasoning for not having all imports at the top of the file could be, in some cases, imports of optional dependencies. Say you want to use the class Lightcurve, but you might not want to plot them, there’s not necessarily a reason for you to import matplotlib, so it could be an import in the method that uses it. I don’t actually know whether that’s a standard thing to do? Same for some of the tests.

I agree we should avoid it wherever possible, but I’m okay with it for optional package dependencies we don’t want to strictly enforce.

[matteobachetti]

I agree @evandromr. Most of the points raised by @TomaszKolek have been addressed, sometimes without specifically referring to this Issue. I close this and we will reopen if needed. Thanks @TomaszKolek!