question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Implement support for argument and reply transformers

See original GitHub issue

Replace stopgap solutions: https://github.com/stipsan/ioredis-mock/blob/cffd1cfc03466442d7bb076dc1385b3af8852c46/src/commands/hmset.js#L9-L18 https://github.com/stipsan/ioredis-mock/blob/cffd1cfc03466442d7bb076dc1385b3af8852c46/src/command.js#L16-L17

with a proper Command.setArgumentTransformer and Command.setReplyTransformer interfaces. As well as including the same default transformers found here: https://github.com/luin/ioredis/blob/b216e4eb61d05ff639b162f23751acb111dde6e8/lib/command.js#L264-L277 https://github.com/luin/ioredis/blob/b216e4eb61d05ff639b162f23751acb111dde6e8/lib/command.js#L279-L289 https://github.com/luin/ioredis/blob/b216e4eb61d05ff639b162f23751acb111dde6e8/lib/command.js#L291-L300

The interface for defining them needs to be 100% compatible with this: https://github.com/luin/ioredis#transforming-arguments--replies

It looks like it means we need to implement it as singletons but this should be properly investigated. It’s very important that the mock does not behave differently than the real ioredis on this.

Issue Analytics

  • State:closed
  • Created 6 years ago
  • Comments:5 (3 by maintainers)

github_iconTop GitHub Comments

1reaction
XVincentXcommented, Nov 18, 2017

That’s one of the goals, exactly!

1reaction
XVincentXcommented, Nov 17, 2017

I’ll make sure to praise you in our next changelog. You’ve been extremely responsive!

Read more comments on GitHub >

github_iconTop Results From Across the Web

Source code for transformers.pipelines - Hugging Face
ArgumentHandler `, `optional`): Reference to the object in charge of parsing supplied pipeline parameters. device (:obj:`int`, `optional`, defaults to -1): ...
Read more >
Response transformer - Basics - Mock Service Worker Docs
Response transformer is a function that transforms a given mocked response instance. Response transformers are also referred to as "context ...
Read more >
nlp - Transformer TFBertForSequenceClassification Error ...
It seems to be a bug in transformers==4.15.0 at least. I fixed it by upgrading to transformers==4.16.2 . Share. Share a link to...
Read more >
BERT Argues: How Attention Informs Argument Mining
Of course thank you to my family and friends for giving me support and love ... While the theory of argumentation, the use...
Read more >
Exploring Argument Retrieval with Transformers - CEUR-WS
Both query expansion approaches make use of an Elasticsearch index where the documents of the args.me corpus were indexed using a language model...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found