question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Make recommended: true by default and fix inheritence

See original GitHub issue

Updated 2019-10-29: Replaced with content from @marbemac’s comment, which will be used to drive this issue.

recommended should be the default across the board - cli and ruleset extension.

E.g. this:

extends: spectral:oas3

Is the same as:

extends: [[spectral:oas3, recommended]]

As far as extending w all, recommended, or none, it should bubble up the hierarchy (I thought that this was happening now, but maybe not?):

E.g. this:

extends: [[foo.json, all]]

Is the same as:

extends: [[bar.json, all], [baz.json, all]]

Todo

  • change recommended to be true by default
  • make sure all rules maintain their recommended status (no accidental changes)
  • audit documentation to make sure there is no statements which disagree (for JS, CLI, rulesets in general, custom functions, etc)

Issue Analytics

  • State:closed
  • Created 4 years ago
  • Comments:16 (14 by maintainers)

github_iconTop GitHub Comments

2reactions
marbemaccommented, Aug 24, 2019

My two cents… recommended should be the default across the board - cli and ruleset extension.

E.g. this:

extends: spectral:oas3

Is the same as:

extends: [[spectral:oas3, recommended]]

As far as extending w all, recommended, or none, it should bubble up the hierarchy (I thought that this was happening now, but maybe not?):

E.g. this:

extends: [[spectral:oas3, all]]

Is the same as:

extends: [[spectral:oas3, all], [spectral:oas, all]]
1reaction
marbemaccommented, Aug 25, 2019

And perhaps a look at the docs to make sure this behavior is described clearly? @philsturgeon maybe you can take this issue and make it about verification that this is happening + docs audit?

Read more comments on GitHub >

github_iconTop Results From Across the Web

Class inheritance in Python 3.7 dataclasses - Stack Overflow
When a dataclass inherits from another dataclass, and the base class has fields with default values, then all of the fields in the...
Read more >
Python dataclass inheritance, finally ! | by Anis Campos
This is what the documentation says about this new feature: kw_only : If true (the default value is False ), then all fields...
Read more >
Inheritance - CSS: Cascading Style Sheets - MDN Web Docs
In CSS, inheritance controls what happens when no value is specified for a property on an element. CSS properties can be categorized in...
Read more >
Inheritance - EF Core | Microsoft Learn
NET entities in code as usual, using base and derived types, and have EF seamlessly create the appropriate database schema, issue queries, etc....
Read more >
Inheritance — What your mother never told you, C++ FAQ
The answer is to make it virtual if you think that some derived class might ... Since that might confuse novices, the C++...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found