[Docs] Clarify vite peer dependency requirements in README
See original GitHub issueWhat version of vite
are you using?
2.9.14
System info and storybook versions
System: OS: macOS 12.3.1 CPU: (8) arm64 Apple M1 Binaries: Node: 16.15.0 - ~/.nvm/versions/node/v16.15.0/bin/node Yarn: 1.22.19 - ~/.yarn/bin/yarn npm: 8.9.0 - ~/.config/yarn/global/node_modules/.bin/npm Browsers: Chrome: 103.0.5060.114 Firefox: 101.0.1 Safari: 15.4 npmPackages: @storybook/addon-actions: ^6.5.9 => 6.5.9 @storybook/addon-essentials: ^6.5.9 => 6.5.9 @storybook/addon-links: ^6.5.9 => 6.5.9 @storybook/addon-postcss: ^2.0.0 => 2.0.0 @storybook/builder-vite: ^0.2.0-beta.1 => 0.2.0-beta.1 @storybook/react: ^6.5.9 => 6.5.9
Describe the Bug
See https://github.com/fwouts/hungry/pull/9 for easy repro (just checkout the branch and run yarn storybook
).
$ yarn storybook
yarn run v1.22.19
$ start-storybook -p 6006
info @storybook/react v6.5.9
info
info => Loading presets
ERR! TypeError: vite.createFilter is not a function
ERR! at viteReact (/Users/fwouts/dev/hungry/node_modules/@vitejs/plugin-react/dist/index.cjs:189:21)
ERR! at pluginConfig (/Users/fwouts/dev/hungry/node_modules/@storybook/builder-vite/dist/vite-config.js:81:36)
ERR! at processTicksAndRejections (node:internal/process/task_queues:96:5)
ERR! at async commonConfig (/Users/fwouts/dev/hungry/node_modules/@storybook/builder-vite/dist/vite-config.js:65:18)
ERR! at async createViteServer (/Users/fwouts/dev/hungry/node_modules/@storybook/builder-vite/dist/vite-server.js:10:24)
ERR! at async Object.start (/Users/fwouts/dev/hungry/node_modules/@storybook/builder-vite/dist/index.js:53:20)
ERR! at async Promise.all (index 0)
ERR! at async storybookDevServer (/Users/fwouts/dev/hungry/node_modules/@storybook/core-server/dist/cjs/dev-server.js:207:28)
ERR! at async buildDevStandalone (/Users/fwouts/dev/hungry/node_modules/@storybook/core-server/dist/cjs/build-dev.js:120:31)
ERR! at async buildDev (/Users/fwouts/dev/hungry/node_modules/@storybook/core-server/dist/cjs/build-dev.js:174:5)
ERR! TypeError: vite.createFilter is not a function
ERR! at viteReact (/Users/fwouts/dev/hungry/node_modules/@vitejs/plugin-react/dist/index.cjs:189:21)
ERR! at pluginConfig (/Users/fwouts/dev/hungry/node_modules/@storybook/builder-vite/dist/vite-config.js:81:36)
ERR! at processTicksAndRejections (node:internal/process/task_queues:96:5)
ERR! at async commonConfig (/Users/fwouts/dev/hungry/node_modules/@storybook/builder-vite/dist/vite-config.js:65:18)
ERR! at async createViteServer (/Users/fwouts/dev/hungry/node_modules/@storybook/builder-vite/dist/vite-server.js:10:24)
ERR! at async Object.start (/Users/fwouts/dev/hungry/node_modules/@storybook/builder-vite/dist/index.js:53:20)
ERR! at async Promise.all (index 0)
ERR! at async storybookDevServer (/Users/fwouts/dev/hungry/node_modules/@storybook/core-server/dist/cjs/dev-server.js:207:28)
ERR! at async buildDevStandalone (/Users/fwouts/dev/hungry/node_modules/@storybook/core-server/dist/cjs/build-dev.js:120:31)
ERR! at async buildDev (/Users/fwouts/dev/hungry/node_modules/@storybook/core-server/dist/cjs/build-dev.js:174:5)
WARN Broken build, fix the error above.
WARN You may need to refresh the browser.
This particular crash disappears if I also install the latest Vite 3 beta.
Suggested solution: Should Vite 3 be an explicit dependency of vite-builder
?
Link to Minimal Reproducible Example
https://github.com/fwouts/hungry/tree/vite-builder-0.2
Participation
- I am willing to submit a pull request for this issue.
Issue Analytics
- State:
- Created a year ago
- Reactions:1
- Comments:11 (6 by maintainers)
After upgrading Vite to v3 it works, thanks for clarifying.
I’m getting some interesting behavior here