Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Addon-a11y: Manual doesn't work

See original GitHub issue

Describe the bug if you add

FullApp.parameters = {
  a11y: {
    manual: true
  }
};

to this example https://github.com/storybookjs/storybook/blob/next/examples/cra-kitchen-sink/src/stories/App.stories.js#L16 you’ll see that the a11y tests are run even though “manual: true” is set.

To Reproduce Steps to reproduce the behavior: See above.

Expected behavior We should be in the manual state where no aXe test is run automatically.

Screenshots

Code snippets I tested a bunch of stuff in order to debug this and fix this on my own, but I didn’t came far.

There might be two problems contributing to this…? https://github.com/storybookjs/storybook/blob/4867e539f68478f878838d270ce34f8c1e86809f/addons/a11y/src/components/A11YPanel.tsx#L54-L64 It once looked like this triggers initial, manual and later initial again…?

It also looks that in some places (for example I think in the following code snippet - but I couldn’t find all places) the EVENTS.REQUEST is triggered without having a check for manual?

https://github.com/storybookjs/storybook/blob/4867e539f68478f878838d270ce34f8c1e86809f/addons/a11y/src/components/A11yContext.tsx#L67-L85

System: next branch.

Environment Info:

System: OS: macOS 10.15.6 CPU: (16) x64 Intel® Core™ i9-9980HK CPU @ 2.40GHz Binaries: Node: 10.16.0 - ~/.nvm/versions/node/v10.16.0/bin/node Yarn: 1.22.4 - ~/.yarn/bin/yarn npm: 6.14.4 - ~/.nvm/versions/node/v10.16.0/bin/npm Browsers: Chrome: 84.0.4147.105 Safari: 13.1.2

Additional context

Issue Analytics

State:
Created 3 years ago
Comments:9 (9 by maintainers)

Top GitHub Comments

1reaction

shilmancommented, Aug 19, 2020

¡Ay Caramba!! I just released https://github.com/storybookjs/storybook/releases/tag/v6.0.13 containing PR #12003 that references this issue. Upgrade today to try it out!

Closing this issue. Please re-open if you think there’s still more to do.

1reaction

tooppaaacommented, Aug 7, 2020

Thanks a lot for your feedback, very helpful ! I’ll try to work on this but that might not be until next week. Want to help on this @donaldpipowitch ?

@shilman not blocker for 6.0, can that be a patch some time later ?

Top Results From Across the Web

A guide to add auto accessibility check in storybook · In the Mist

Storybook has an official addon called @storybook/addon-a11y ... a form that doesn't work well with VoiceOver, still need manual checks.

Make your PowerPoint presentations accessible to people ...

This topic gives you step-by-step instructions and best practices for making your PowerPoint presentations accessible and unlock your content to everyone, ...

Accessibility. Storybook | by Kruthi Venkatesh - Medium

Storybook-addon-a11y is an addon offered by the storybook to validate accessibility requirements. It is created by the storybook core team and ...

@storybook/addon-a11y | Yarn - Package Manager

Build bulletproof UI components faster. Build Status on CircleCI CodeFactor Known Vulnerabilities codecov License Storybook Community Backers on Open ...

Links - Usability & Web Accessibility - Yale University

If the ARIA label does not match the link text at least in part, speech recognition software may not work as a user...