question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

[addon-centered] Peer dependencies

See original GitHub issue

Describe the bug The @storybook/addon-centered package has the following peerDependencies:

{
  "peerDependencies": {
    "mithril": "*",
    "preact": "*",
    "react": "*"
  }
}

Meaning installing it will always add 2-3 annoying warnings to a project. You’ll never have more than 1 of those installed at the same time, and you can even use the addon without any of them.

Expected behavior A package should not have peerDependencies that can’t/won’t ever be met. Please find a better solution (optionalDependencies?), or just remove the peerDependencies all together in this case.

Issue Analytics

  • State:closed
  • Created 4 years ago
  • Reactions:2
  • Comments:6 (4 by maintainers)

github_iconTop GitHub Comments

2reactions
shilmancommented, Sep 5, 2019

Hey @leoyli here you go go go!! 🚀

1reaction
leoylicommented, Sep 27, 2019

@Svish, yes fixed, stay tune 👀

Read more comments on GitHub >

github_iconTop Results From Across the Web

Understanding Peer Dependencies in JavaScript
When to use peerDependencies? Peer dependencies really come into play when you're developing code that will be used by others, such as plugins ......
Read more >
@storybook/addon-centered@5.3.21 - jsDocs.io
Documentation for npm package @storybook/addon-centered@5.3.21 - jsDocs.io. ... Index; Files; Dependencies (Dev, Peer); Badge; Versions ...
Read more >
What are peer dependencies in a Node module? - Flavio Copes
A simple explanation of the peerDependencies field in the package.json file.
Read more >
peerDependencies - Code Search
Results 1 - 1 of 1 for peerDependencies (11.69 sec). organization; storybookjs 1 ... Addon-centered/contexts: Move optionalDependencies to peerDependencies ...
Read more >
@boomerang-io/carbon-addons-boomerang-react - npm
v2 · Move @carbon/icons-react to a peer dependency · Move carbon-icons to a peer dependency · Remove @carbon/elements as a dependency · No...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found