Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

[addon-contexts] Should I add global and qs to my package.json?

See original GitHub issue

Describe the bug When adding the context addon package to my project as suggested in the README. I receive the following warning from yarn:

warning " > @storybook/addon-contexts@5.1.9" has unmet peer dependency "global@*".
warning " > @storybook/addon-contexts@5.1.9" has unmet peer dependency "qs@*".

It appears that these two packages are listed as peer dependencies in the package.json of @storybook/addon-contexts@5.1.9. However the README doesn’t mention that these two package should be installed ‘manually’.

Expected behavior When following the README instructions, not to be left with warnings from yarn.

Either the README should mention we should install these packages together with the addon, or these packages should be added as real dependencies of the addon, not just peer dependencies.

System:

Binaries:
    Node: 10.15.0 - ~/.nvm/versions/node/v10.15.0/bin/node
    Yarn: 1.17.3 - /usr/bin/yarn
    npm: 6.8.0 - ~/.nvm/versions/node/v10.15.0/bin/npm

Issue Analytics

State:
Created 4 years ago
Reactions:2
Comments:22 (13 by maintainers)

Top GitHub Comments

2reactions

shilmancommented, Jul 31, 2019

@leoyli I think it’s fine to put them as regular dependencies in this case. We should use peer deps when we want to use the user’s version. But I don’t think it matters in this case?

1reaction

shilmancommented, Jan 31, 2020

@Sjiep That’s pretty weird. Perhaps some bad conflict resolution at some point? I’m reopening & will try to re-apply these changes to both next and master when I get back to work (on vacation).

Top Results From Across the Web

@storybook/addon-contexts - npm package | Snyk

An important project maintenance signal to consider for @storybook/addon-contexts is that it hasn't seen any new versions released to npm in the past...

@storybook/addon-toolbars | Yarn - Package Manager

The Toolbars addon controls global story rendering options from Storybook's toolbar UI. It's a general purpose addon that can be used to: set...

Storybook: how to update i18 locale depending on globals

I don't know how to watch for this global change to update my i18n and the language direction. In the doc, the global...

Files changed (215) - Renovate Bot Package Diff

We now read package.json using `pkgUp`, so theoretically you can run `chromatic` from a subdirectory. 100. - - Added the `--output-dir (-o)` flag...

microbundle - Bountysource

Also, my components use React (.js only no TS) and CSS modules. The package.json of a sample package looks like this: { "name":...