Addon docs - Docgen regression with spead props

Describe the bug Composed props are not displayed anymore in the generated docs.

Last working version: 5.2.8 The next is not working anymore: 5.3.0-alpha.0 (RC-1 and RC-4 also verifed)

To Reproduce Steps to reproduce the behavior:

1. Create a component with its story
2. Define propTypes with spread:

AudioPlayerWidget.propTypes = {
  /**
   * All these props coming from elsewhere are not displayed anymore
   */
  ...Widget.propTypes,

  /**
   * This prop is displayed correctly
   */
  sample: PropTypes.number
};

Expected behavior The name (and only the name) of the prop should be displayed. I don’t expect type, description and default value as the problem for these fields come from the React-docgen which does not support prop composition (https://github.com/reactjs/react-docgen/issues/151).

System: React 16

[patricklafrance]

@ylacaute this is how I fixed it in my design system until the issue is solved in react-docgen:

https://github.com/gsoft-inc/sg-orbit/blob/master/packages/react-components/components/date-picker/src/range/date-range-picker.jsx#L14

IMO it’s better than adding back a fallback in storybook docs that will only partially render the prop. It’s ugly but you’ll get a proper rendering with the prop name & type.

[ylacaute]

I agree with you, don’t add this fallback.

From what I understand, all your DatePick declare all props directly, you don’t factorize the props definition, that is exaclty what I was tried to not do but it is not a big deal, I will do the same 😃

I will give a closer look at Orbit, it seems a very nice project !! Thank you for sharing.