question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

addon-jest test total and time total overlap "Todo" text on small screens.

See original GitHub issue

Describe the bug A clear and concise description of what the bug is.

To Reproduce Steps to reproduce the behavior:

  1. Go to ‘https://storybookjs.now.sh/official-storybook/?path=/story/addons-jest--with-tests’ in a narrow width browser.
  2. Click on the Tests panel.
  3. Scroll down to see the tests panel.
  4. See the total number of tests and total time covering up the “Todo” text.

Expected behavior The text does not overlap.

Screenshots If applicable, add screenshots to help explain your problem. Screen Shot 2019-10-28 at 1 55 41 PM Code snippets If applicable, add code samples to help explain your problem.

System: Please paste the results of npx -p @storybook/cli@next sb info here.

System:
    OS: macOS Mojave 10.14.6
    CPU: (12) x64 Intel(R) Core(TM) i7-8750H CPU @ 2.20GHz
  Binaries:
    Node: 10.16.3 - /usr/local/bin/node
    npm: 6.12.0 - /usr/local/bin/npm
  Browsers:
    Chrome: 77.0.3865.90
    Firefox: 69.0.2
    Safari: 12.1.2
  npmPackages:
    @storybook/addon-a11y: ^5.2.5 => 5.2.5
    @storybook/addon-actions: ^5.2.5 => 5.2.5
    @storybook/addon-docs: ^5.2.5 => 5.2.5
    @storybook/addon-jest: ^5.2.5 => 5.2.5
    @storybook/addon-knobs: ^5.2.5 => 5.2.5
    @storybook/addon-links: ^5.2.5 => 5.2.5
    @storybook/addons: ^5.2.5 => 5.2.5
    @storybook/react: ^5.2.5 => 5.2.5
    @storybook/theming: ^5.2.5 => 5.2.5

Additional context I looked into this a little bit and discovered that the Accessibility addon has solved this issue by dropping down the “highlight results” checkbox to the next line. The total tests and total time for for the addon-jest is absolutely positioned and seems to be setup a bit differently than that addon.

Issue Analytics

  • State:open
  • Created 4 years ago
  • Comments:5 (3 by maintainers)

github_iconTop GitHub Comments

6reactions
garyvh2commented, Oct 30, 2019

@domyen sounds good, so we are looking for a standard implementation on TabsState component from the lib, with something like what you mentioned above?

I’ll work on a possible solution integrating both addons with the same component.

3reactions
domyencommented, Oct 30, 2019

Ideally, we’d use the same Tab component in Jest and A11y addons. I think the a11y addon has the correct design for this case so further investment in css for just this addon would end up diverging both further.

@garyvh2 Would you be keen to help consolidate the tab implementations to solve this once and for all for everyone? I’d imagine it’d be a standard tab component + a prop that allowed you to render a node in the top right.

Read more comments on GitHub >

github_iconTop Results From Across the Web

How To Test a React App with Jest and React Testing Library
Both Jest and React Testing Library come pre-packaged with Create ... 1 total Tests: 1 passed, 1 total Snapshots: 0 total Time: 2.595...
Read more >
vscode-jest - Visual Studio Marketplace
This extension supports full jest features in vscode environment to make testing more intuitive and fun. It should work out-of-the-box for ...
Read more >
Testing a Svelte app with Jest - Rob O'Leary
In this tutorial, I will go through using Svelte with Vite, and show you how to test a complete app with Jest. I...
Read more >
CHANGELOG.md ... - GitLab
Fixed expand full file button showing on images. ... overlapping navbar separator and overflowing navbar dropdown on small displays. !23126 (Thomas Pathier) ...
Read more >
https://ruibals.com/wp-content/plugins/woocommerce...
The plugin includes new and improved reports and a dashboard to monitor key ... Fix: Advanced filters screen reader text #5032 - Fix:...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found