question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Angular: Storybook 6.3 stopped supporting Cyrillic in title in stories

See original GitHub issue

Describe the bug Our project was updated to Angular 12, Storybook stopped working after that. I concluded that support is only expected in version 6.3. I waited for the beta versions of Storybook 6.3, updated to one of them. All stories broke, an error like this appeared:

Template parse errors:
Unexpected closing tag "-button--primary". It may happen when the tag has already been closed by another tag. For more info see https://www.w3.org/TR/html5/syntax.html#closing-elements-that-have-implied-end-tags ("<-button--primary>[ERROR ->]</-button--primary>"): @0:18

Followed all steps from MIGRATION.MD, didn’t help. I tried to put it all over again in a new project, with my stories, the error was in it. The difference was found only in the title property, in our project there was Cyrillic. At the same time, the mdx files did not break, only the stories themselves inside them, if there were

To Reproduce

Repository Gh-pages

System

  System:
    OS: Windows 10 10.0.19041
    CPU: (12) x64 Intel(R) Core(TM) i7-10750H CPU @ 2.60GHz      
  Binaries:
    Node: 14.15.0 - C:\Program Files\nodejs\node.EXE
    Yarn: 1.22.5 - C:\Program Files (x86)\Yarn\bin\yarn.CMD      
    npm: 6.14.8 - C:\Program Files\nodejs\npm.CMD
  Browsers:
    Edge: Spartan (44.19041.964.0), Chromium (91.0.864.41)       
  npmPackages:
    @storybook/addon-actions: ^6.3.0-beta.11 => 6.3.0-beta.11    
    @storybook/addon-essentials: ^6.3.0-beta.11 => 6.3.0-beta.11 
    @storybook/addon-links: ^6.3.0-beta.11 => 6.3.0-beta.11      
    @storybook/angular: ^6.3.0-beta.11 => 6.3.0-beta.11
    @storybook/builder-webpack5: ^6.3.0-beta.11 => 6.3.0-beta.11 
    @storybook/manager-webpack5: ^6.3.0-beta.11 => 6.3.0-beta.11 

Additional context

My package.json

{
  "name": "zettel",
  "version": "0.0.0",
  "scripts": {
    "ng": "ng",
    "start": "ng serve -o --host 0.0.0.0",
    "build": "ng build",
    "watch": "ng build --watch --configuration development",
    "test": "ng test",
    "docs:json": "compodoc -p ./tsconfig.json -e json -d .",
    "storybook": "npm run docs:json && start-storybook -p 6006",
    "build-storybook": "npm run docs:json && build-storybook"
  },
  "private": true,
  "dependencies": {
    "@angular/animations": "~12.0.0",
    "@angular/common": "~12.0.0",
    "@angular/compiler": "~12.0.0",
    "@angular/core": "~12.0.0",
    "@angular/forms": "~12.0.0",
    "@angular/platform-browser": "~12.0.0",
    "@angular/platform-browser-dynamic": "~12.0.0",
    "@angular/router": "~12.0.0",
    "rxjs": "~6.6.0",
    "tslib": "^2.1.0",
    "zone.js": "~0.11.4"
  },
  "devDependencies": {
    "@angular-devkit/build-angular": "~12.0.0",
    "@angular/cli": "~12.0.0",
    "@angular/compiler-cli": "~12.0.0",
    "@babel/core": "^7.14.3",
    "@compodoc/compodoc": "^1.1.11",
    "@storybook/addon-actions": "^6.3.0-beta.11",
    "@storybook/addon-essentials": "^6.3.0-beta.11",
    "@storybook/addon-links": "^6.3.0-beta.11",
    "@storybook/angular": "^6.3.0-beta.11",
    "@storybook/builder-webpack5": "^6.3.0-beta.11",
    "@storybook/manager-webpack5": "^6.3.0-beta.11",
    "@types/jasmine": "~3.6.0",
    "@types/node": "^12.11.1",
    "babel-loader": "^8.2.2",
    "jasmine-core": "~3.7.0",
    "karma": "~6.3.0",
    "karma-chrome-launcher": "~3.1.0",
    "karma-coverage": "~2.0.3",
    "karma-jasmine": "~4.0.0",
    "karma-jasmine-html-reporter": "^1.5.0",
    "typescript": "~4.2.3"
  }
}

My main.js:

module.exports = {
  "stories": [
    "../src/**/*.stories.mdx",
    "../src/**/*.stories.@(js|jsx|ts|tsx)"
  ],
  "addons": [
    "@storybook/addon-links",
    "@storybook/addon-essentials"
  ],
  "core": {
    "builder": "webpack5"
  },
}

stories.ts file with an error (based on the standard example):


import { Story, Meta } from '@storybook/angular/types-6-0';
import Button from './button.component';

export default {
  title: 'Пример/Button',
  component: Button
} as Meta;

const Template: Story<Button> = (args: Button) => ({
  props: args,
});

export const Primary = Template.bind({});
Primary.args = {
  primary: true,
  label: 'Button',
};

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Comments:15 (8 by maintainers)

github_iconTop GitHub Comments

3reactions
nagashimamcommented, Dec 9, 2021

@shilman @ThibaudAV @yannbf Thank you so much for your kind help!We have more than 400stories and all the titles are Japanese. Now we don’t need to rewrite all of them😄

3reactions
shilmancommented, Dec 9, 2021

Son of a gun!! I just released https://github.com/storybookjs/storybook/releases/tag/v6.5.0-alpha.2 containing PR #16931 that references this issue. Upgrade today to the @next NPM tag to try it out!

npx sb upgrade --prerelease
Read more comments on GitHub >

github_iconTop Results From Across the Web

Angular: Storybook 6.3 stopped supporting Cyrillic in title in stories ...
Describe the bug Our project was updated to Angular 12, Storybook stopped working after that. I concluded that support is only expected in...
Read more >
Storybook 6.3 - JS.ORG
Storybook is the industry-standard UI development workshop for components and pages. It's used by Dropbox, Shopify, Stripe, and thousands ...
Read more >
@storybook/angularの6.3以降で日本語をタイトルにできない
Angular : Storybook 6.3 stopped supporting Cyrillic in title in stories · Issue #15147 · storybookjs/. Describe the bug Our project was ...
Read more >
nwL - River Thames Conditions - Environment Agency - GOV.UK
Book nook dalton hours, Samoyed puppy tumblr, Soi romanee guesthouse, ... Arshi dark love stories, Anmachtipps im chat, Meningkatkan kualitas sinyal hp, ...
Read more >
Understanding Music - University of North Georgia
York Philharmonic and composer of the music of West Side Story. ... trombone improvises supporting notes that outline the harmony of the song...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found