API.setQueryParams not works as expected

Describe the bug Expected URL updated when api.setQueryParams get called.

To Reproduce Steps to reproduce the behavior:

• In any add-on tooltip component, where get access with storybookAPI, call storybookAPI.setQueryParams({ foo: 'bar' }).

Expected behavior URL change to, for example: http://localhost:6006/?path=/story/test&foo=bar.

System:

• OS: MacOS Mojave
• Device: MacBook Air 2013-mid
• Browser: Chrome 72
• Framework: React 16.8.1
• Version: v5.0.0-beta.2

Additional context Related #5271

if call the following immediately

console.log(api.getQueryParam('foo')) // `bar` printed

Therefore, it is working (previously in alpha.11 is not working though), but the URL is not changing. Also, by directly change the URL state like http://localhost:6006/?path=/story/test&foo=bez. 'bez' get printed correctly, but the URL changed to http://localhost:6006/?path=//story/test. It added additional slash after ?path mysteriously… And if refresh the page, no 'bez' get printed.

[uriel-sf]

If the API is called set/get query params, you kinda expect it to work that way 😃 How about instead of changing its behavior, this API is slowly deprecated over several releases? That would probably be better for devs expecting the API to work like it did before (myself included).

[leoyli]

@tmeasday Here gives me some confusions, does any reason we don’t want the URL keep the query parameter?! Ideally, I would like to share the URL to other people, let’s say for designer. That would be super useful for our communication.

The biggest reason for me to have query in URL is for testing. I have add-on work for this (e.g. &themes=dark&languages=english), this gives us the ability to mock a particular environment state that the component is reacted to (i.e theming or language). It would be nice we can have this kept when we “open the component into a new tab”, then we can copy past URL without manually typing those parameters.

In our team, we want to have at least 1 story per dummy components and they are smartly knobbed and auto-generated. For some special variants (i.e. component specific) we will have more granular-defined stories to document some important use case so we can cherry-pick them for smoke testing.