Error post RC upgrade

Describe the bug

I was running v6.0-rc23 and decided to upgrade to the latest release candidate by running:

NOTE: I had a fully functional Storybook instance pre-upgrade to rc-26

npx sb@next upgrade --prelease

The process “completes” but then threw the following error:

(node:79621) UnhandledPromiseRejectionWarning: Error: No storybook core packages found!

Full trace:

success Saved lockfile.
✨  Done in 41.61s.
. ✓
(node:79621) UnhandledPromiseRejectionWarning: Error: No storybook core packages found!
    at checkVersionConsistency (/Users/schalkneethling/.npm/_npx/79621/lib/node_modules/sb/node_modules/@storybook/cli/dist/upgrade.js:61:11)
    at upgrade (/Users/schalkneethling/.npm/_npx/79621/lib/node_modules/sb/node_modules/@storybook/cli/dist/upgrade.js:120:19)
    at Command.<anonymous> (/Users/schalkneethling/.npm/_npx/79621/lib/node_modules/sb/node_modules/@storybook/cli/dist/generate.js:38:407)
    at Command.listener [as _actionHandler] (/Users/schalkneethling/.npm/_npx/79621/lib/node_modules/sb/node_modules/commander/index.js:413:31)
    at Command._parseCommand (/Users/schalkneethling/.npm/_npx/79621/lib/node_modules/sb/node_modules/commander/index.js:914:14)
    at Command._dispatchSubcommand (/Users/schalkneethling/.npm/_npx/79621/lib/node_modules/sb/node_modules/commander/index.js:865:18)
    at Command._parseCommand (/Users/schalkneethling/.npm/_npx/79621/lib/node_modules/sb/node_modules/commander/index.js:882:12)
    at Command.parse (/Users/schalkneethling/.npm/_npx/79621/lib/node_modules/sb/node_modules/commander/index.js:717:10)
    at Object.<anonymous> (/Users/schalkneethling/.npm/_npx/79621/lib/node_modules/sb/node_modules/@storybook/cli/dist/generate.js:96:70)
    at Module._compile (internal/modules/cjs/loader.js:1201:30)
(Use `node --trace-warnings ...` to show where the warning was created)
(node:79621) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
(node:79621) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

Attempting to run Storybook now results in the following error:

yarn run v1.22.4
$ yarn workspace client storybook
$ start-storybook -p 9009 -s public
info @storybook/react v6.0.0-rc.26
info 
info => Loading static files from: /Users/schalkneethling/repos/yari/client/public .
info => Loading presets
info => Loading presets
info => Loading config/preview file in "./.storybook".
info => Loading config/preview file in "./.storybook".
info => Loading Webpack configuration from `../node_modules/react-scripts`
info => Removing existing JavaScript and TypeScript rules.
info => Modifying Create React App rules.
ERR! Error: Cannot find module 'babel-loader'
ERR! Require stack:
ERR! - /Users/schalkneethling/repos/yari/node_modules/@storybook/addon-docs/dist/frameworks/common/preset.js
ERR! - /Users/schalkneethling/repos/yari/node_modules/@storybook/core/dist/server/presets.js
ERR! - /Users/schalkneethling/repos/yari/node_modules/@storybook/core/dist/server/config.js
ERR! - /Users/schalkneethling/repos/yari/node_modules/@storybook/core/dist/server/build-static.js
ERR! - /Users/schalkneethling/repos/yari/node_modules/@storybook/core/server.js
ERR! - /Users/schalkneethling/repos/yari/node_modules/@storybook/react/dist/server/index.js
ERR! - /Users/schalkneethling/repos/yari/node_modules/@storybook/react/bin/index.js
ERR!     at Function.Module._resolveFilename (internal/modules/cjs/loader.js:1030:15)
ERR!     at Function.resolve (internal/modules/cjs/helpers.js:81:19)
ERR!     at Object.webpack (/Users/schalkneethling/repos/yari/node_modules/@storybook/addon-docs/dist/frameworks/common/preset.js:167:27)
ERR!     at /Users/schalkneethling/repos/yari/node_modules/@storybook/core/dist/server/presets.js:258:36
ERR!     at async Promise.all (index 1)
ERR!     at async buildDevStandalone (/Users/schalkneethling/repos/yari/node_modules/@storybook/core/dist/server/build-dev.js:438:28)
ERR!     at async buildDev (/Users/schalkneethling/repos/yari/node_modules/@storybook/core/dist/server/build-dev.js:520:3)
ERR!  Error: Cannot find module 'babel-loader'

To Reproduce Steps to reproduce the behavior:

1. Have RC candidate release 23 installed
2. Run npx sb@next upgrade --prelease

Expected behavior

Upgrade completes without error.

System: Please paste the results of npx -p @storybook/cli@next sb info here.

Additional context

Environment Info:

System: OS: macOS 10.15.5 CPU: (8) x64 Intel® Core™ i7-7920HQ CPU @ 3.10GHz Binaries: Node: 14.5.0 - /usr/local/bin/node Yarn: 1.22.4 - /usr/local/bin/yarn npm: 6.14.5 - /usr/local/bin/npm Browsers: Firefox: 78.0.2 Safari: 13.1.1

[shilman]

Hurrah!! I just released https://github.com/storybookjs/storybook/releases/tag/v6.0.6 containing PR #11993 that references this issue. Upgrade today to try it out!

Closing this issue. Please re-open if you think there’s still more to do.

[schalkneethling]

@schalkneethling @sakulstra the upgrade script uses npm ls and looks for the package version for @storybook/*. when it throws that No storybook core packages found! it means that it couldn’t find any of those packages installed. what happens when you run npm ls by hand on the command line?

Dang, I am unfortunately(fortunately? :slight_smile: ) not in that broken state anymore. I am going to bump the version of the RC today. Should this happen again, I will be sure to run the command and let you know the output.