question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Ignore private members and methods from Custom Elements Manifest

See original GitHub issue

Describe the bug The new setCustomElementsManifest method correctly loads a Custom Element Manifest and it populates properties in the API table, but it does not filter private members using the privacy field in the manifest.

To Reproduce https://github.com/edoardocavazza/custom-elements-manifest-private-members

Run the storybook and open docs page.

System

Environment Info:

  System:
    OS: macOS 11.3
    CPU: (12) x64 Intel(R) Core(TM) i7-8850H CPU @ 2.60GHz
  Binaries:
    Node: 15.14.0 - ~/.nvm/versions/node/v15.14.0/bin/node
    Yarn: 2.4.2 - /usr/local/bin/yarn
    npm: 7.7.6 - ~/.nvm/versions/node/v15.14.0/bin/npm
  Browsers:
    Edge: 91.0.864.48
    Firefox: 89.0
    Safari: 14.1
  npmPackages:
    @storybook/addon-actions: ^6.4.0-alpha.9 => 6.4.0-alpha.9 
    @storybook/addon-docs: ^6.4.0-alpha.9 => 6.4.0-alpha.9 
    @storybook/addon-essentials: ^6.4.0-alpha.9 => 6.4.0-alpha.9 
    @storybook/addon-links: ^6.4.0-alpha.9 => 6.4.0-alpha.9 
    @storybook/web-components: ^6.4.0-alpha.9 => 6.4.0-alpha.9

Issue Analytics

  • State:open
  • Created 2 years ago
  • Reactions:6
  • Comments:11 (4 by maintainers)

github_iconTop GitHub Comments

5reactions
WillGellercommented, Feb 8, 2022

@thepassle My team would greatly appreciate a privateFields: false option on setCustomElementsManifest, we hold a similar viewpoint to @dschwank and feel that it is valuable for the CEM to have all the metadata reflective of the web components internals, but it would be great to have Storybook give us the option to hide @state() private type of properties from the Storybook docs, which is largely used to tell component library consumers the input/output API of the components, not it’s underlying implimentation.

3reactions
dschwankcommented, Feb 10, 2022

Thanks for sharing @thepassle & @WillGeller !

So let’s try to go with a privateFields option. Has anyone started with the implementation already? If not, then I would make a first draft where we could continue the discussion. ✌️

Read more comments on GitHub >

github_iconTop Results From Across the Web

Configuration - Custom Elements Manifest
Command/option, Type, Description, Example. analyze, Analyze your components. --config, string, Path to custom config location, --config ".
Read more >
Option to ignore case with .contains method? - Stack Overflow
I have an ArrayList of DVD object. Each DVD object has a few elements, one of them is a title. And I have...
Read more >
App manifest schema for Teams - Microsoft Learn
In this article, you'll have the latest version of the public manifest schema for Microsoft Teams reference, schema and sample full ...
Read more >
<activity> | Android Developers
... must be represented by {@code } elements in the manifest file. ... This attribute is ignored if FLAG_ACTIVITY_RESET_TASK_IF_NEEDED is ...
Read more >
Safari Technology Preview Release Notes - Apple Developer
Note: Shared Tab Groups and syncing for Tab Groups, Website Settings, and Web Extensions are not enabled in this release. Web Inspector. Elements...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found