Missing ts-pnp dependency

Installing @storybook/react@5.1.9, I’m now presented with the following warning from npm:

npm WARN ts-pnp@1.1.2 requires a peer of typescript@* but none is installed. You must install peer dependencies yourself.

That leads me to:

> npm ls ts-pnp
project@4.8.2 C:\Users\nope\git\project
`-- @storybook/react@5.1.9
  `-- @storybook/core@5.1.9
    `-- pnp-webpack-plugin@1.4.3
      `-- ts-pnp@1.1.2

Which was introduced in commit https://github.com/storybookjs/storybook/commit/c28af59e7db496ed01cec55dab70c98916d5d858 by @crubier. Why am I being asked to install typescript things in my not-typescript repo?

[crubier]

Hmm this seems to be a limitation of pnp-webpack-plugin, which is kind of “hardcoded” to use typescript: https://github.com/arcanis/pnp-webpack-plugin#ts-loader-integration

I didn’t see this problem as I tested it in a project that already uses typescript…

To be fair I think that commit https://github.com/storybookjs/storybook/commit/c28af59e7db496ed01cec55dab70c98916d5d858 can be reverted as the solution we found afterwards was to use storybook presets.

[stale[bot]]

Hey there, it’s me again! I am going close this issue to help our maintainers focus on the current development roadmap instead. If the issue mentioned is still a concern, please open a new ticket and mention this old one. Cheers and thanks for using Storybook!