question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Relative links in md files are broken in v6.1.12

See original GitHub issue

Hi guys,

We are using md files to display component’s documentation under Docs, some of those files have relative links to other stories. For example:

[web](/docs/components-navigation-navigation-framework--default) 

which should navigate to http 😕/localhost:6006/?path=/docs/components-navigation-navigation-framework–default, but after updating SB from v6.1.11 to 6.1.12 it goes to http: //localhost:6006/iframe.html?path=/docs/components-navigation-navigation-framework--default. As you can see, “iframe.html?” is being added to the url, as the result page cannot be found.

@shilman, @ndelangen, I took a look at the change log and it seems that it was broken here: Addon-docs: Fix link not working cross origin (#13022)

System OS: Windows 10 10.0.19042 CPU: (8) x64 Intel® Core™ i7-4940MX CPU @ 3.10GHz Binaries: Node: 14.15.3 - C:\Program Files\nodejs\node.EXE Yarn: 1.22.5 - C:\Program Files (x86)\Yarn\bin\yarn.CMD npm: 6.14.9 - C:\Program Files\nodejs\npm.CMD Browsers: Chrome: 87.0.4280.141 Edge: Spartan (44.19041.423.0), Chromium (87.0.664.75) npmPackages: @storybook/addon-a11y: ^6.1.12 => 6.1.14 @storybook/addon-actions: ^6.1.12 => 6.1.14 @storybook/addon-docs: ^6.1.12 => 6.1.14 @storybook/addon-knobs: ^6.1.12 => 6.1.14 @storybook/addon-links: ^6.1.12 => 6.1.14 @storybook/addon-storysource: ^6.1.12 => 6.1.14 @storybook/addon-viewport: ^6.1.12 => 6.1.14 @storybook/addons: ^6.1.12 => 6.1.14 @storybook/angular: ^6.1.12 => 6.1.14 @storybook/source-loader: ^6.1.12 => 6.1.14

┆Issue is synchronized with this Asana task by Unito

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Comments:9 (5 by maintainers)

github_iconTop GitHub Comments

1reaction
mgameovercommented, Mar 26, 2021

Hi @shilman,

I’ve just created a repo: https://github.com/mgameover/sb-md-relative-links Please take a look.

To reproduce the issue:

  1. npm run storybook
  2. goto “Markdowm / Link test” story, “Docs” tab
  3. click on “test link”

Result: You will be navigated to http://localhost:6006/iframe.html?path=/docs/markdown--target Expected result: You should be navigated to “Markdown / Target” story, “Docs” tab

Hope that helps

1reaction
ndelangencommented, Mar 25, 2021

Hello @mgameover,

I found a fix for this, should be fixed real soon. thanks for reporting!

Read more comments on GitHub >

github_iconTop Results From Across the Web

Relative link in readme broken if readme viewed automatically ...
Within this README.md file I have a link so another .md file which is located in the same repo ind the same folder...
Read more >
Relative links in markup files - The GitHub Blog
Product. Relative links in markup files. We show rendered markup in several places on GitHub, most notably including a project's main README ...
Read more >
Changelog - Cypress Documentation
Fixed an issue with Angular Component Testing where urls within SASS/SCSS files were not being correctly resolved which could result in incomplete styling....
Read more >
Changelog and Migration Guide - Detekt
We're looking into using this feature in some first party rule starting from Detekt 1.22.0 . We now report as warnings the Strings...
Read more >
Bug listing with status UNCONFIRMED as at 2022/12/24 17 ...
... and configuration files" status:UNCONFIRMED resolution: severity:enhancement ... Bug:430756 - "vim-doc.eclass creates broken links when ROOT is not ...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found