Relative links in md files are broken in v6.1.12
See original GitHub issueHi guys,
We are using md files to display component’s documentation under Docs, some of those files have relative links to other stories. For example:
[web](/docs/components-navigation-navigation-framework--default)
which should navigate to http 😕/localhost:6006/?path=/docs/components-navigation-navigation-framework–default, but after updating SB from v6.1.11 to 6.1.12 it goes to http: //localhost:6006/iframe.html?path=/docs/components-navigation-navigation-framework--default. As you can see, “iframe.html?” is being added to the url, as the result page cannot be found.
@shilman, @ndelangen, I took a look at the change log and it seems that it was broken here: Addon-docs: Fix link not working cross origin (#13022)
System OS: Windows 10 10.0.19042 CPU: (8) x64 Intel® Core™ i7-4940MX CPU @ 3.10GHz Binaries: Node: 14.15.3 - C:\Program Files\nodejs\node.EXE Yarn: 1.22.5 - C:\Program Files (x86)\Yarn\bin\yarn.CMD npm: 6.14.9 - C:\Program Files\nodejs\npm.CMD Browsers: Chrome: 87.0.4280.141 Edge: Spartan (44.19041.423.0), Chromium (87.0.664.75) npmPackages: @storybook/addon-a11y: ^6.1.12 => 6.1.14 @storybook/addon-actions: ^6.1.12 => 6.1.14 @storybook/addon-docs: ^6.1.12 => 6.1.14 @storybook/addon-knobs: ^6.1.12 => 6.1.14 @storybook/addon-links: ^6.1.12 => 6.1.14 @storybook/addon-storysource: ^6.1.12 => 6.1.14 @storybook/addon-viewport: ^6.1.12 => 6.1.14 @storybook/addons: ^6.1.12 => 6.1.14 @storybook/angular: ^6.1.12 => 6.1.14 @storybook/source-loader: ^6.1.12 => 6.1.14
┆Issue is synchronized with this Asana task by Unito
Issue Analytics
- State:
- Created 3 years ago
- Comments:9 (5 by maintainers)
Top GitHub Comments
Hi @shilman,
I’ve just created a repo: https://github.com/mgameover/sb-md-relative-links Please take a look.
To reproduce the issue:
Result: You will be navigated to http://localhost:6006/iframe.html?path=/docs/markdown--target Expected result: You should be navigated to “Markdown / Target” story, “Docs” tab
Hope that helps
Hello @mgameover,
I found a fix for this, should be fixed real soon. thanks for reporting!