S and A hotkeys are swapped after entering Fullscreen mode

Describe the bug After entering full-screen mode, the first press of s or a is swapped - s opens the addon panel, and a opens the sidebar. Subsequent presses behave correctly, but the issue repeats if “Go Fullscreen” is selected again.

To Reproduce

1. Create a temporary folder and navigate to it.
2. npx create-react-app my-react-app, cd my-react-app, npx -p @storybook/cli sb init
3. yarn storybook
4. Press a; the addon panel toggles.
5. Press s; the sidebar toggles.
6. Press f to enter full-screen mode.
7. Press a; the sidebar toggles.
8. Press a again; the addon panel toggles.
9. Press f to reset into full-screen mode again.
10. Press s; the addon panel toggles.
11. Press s; the sidebar toggles.

Expected behavior The shortcut keys should always target the correct panel.

System:

• OS: Ubuntu 18.04
• Device: 2018 Asus Vivobook
• Browser: Chrome 72, Firefox Quantum 66
• Framework: React
• Version: Storybook 5.0.6, React 16.8.6

[Phoenixton]

@jalovatt You’re very much welcome 😃 I agree with your proposal on the whole, it seems quite logical to me.

Something like this would correspond to your proposal, imo:

1. Go to fullscreen -> isFullscreen = true, just the way it is right now
2. TogglePanel()/ToggleNav() -> if (isFullscreen), leave fullscreen, close everything (addon panel, sidebar) and open the appropriate window (addon Panel in TogglePanel(), sidebar in ToggleNav() and so on)

This handles the fact that if you just ToggleFullscreen() and then toggle it again without touching anything else, you would revert to your old state, which is the behavior I would expect, and this doesn’t make us declare additional variables. Whaddya think?

[shilman]

Ta-da!! I just released https://github.com/storybooks/storybook/releases/tag/v5.1.0-alpha.28 containing PR #6525 that references this issue. Upgrade today to try it out!

Because it’s a pre-release you can find it on the @next NPM tag.

Closing this issue. Please re-open if you think there’s still more to do.