SB5 Theming breaks React 15 compat
See original GitHub issueThe problem
Currently theming operates in config.js
which is “preview” code (user code). It requires Emotion, which in turn requires React 16.3+.
In 5.0.x
the workaround is to not theme Storybook.
This breaks in 5.1.x
, probably due to https://github.com/storybooks/storybook/pull/6435
I’ve created an example and added it to the repo so we can discuss around it, and also to make sure we don’t inadvertently break back-compat in the future. Coming in a PR shortly.
The solution
Allow users to configure the manager separately from the preview, as relates to https://github.com/storybooks/storybook/issues/4796 https://github.com/storybooks/storybook/issues/4995
- split out
create
into its own file - update documentation
Issue Analytics
- State:
- Created 4 years ago
- Reactions:1
- Comments:8 (6 by maintainers)
Top Results From Across the Web
SB5 Theming breaks React 15 compat · Issue #6474
The problem Currently theming operates in config.js which is "preview" code (user code). It requires Emotion, which in turn requires React ...
Read more >React v15.0 – React Blog
As usual with major releases, React 15 will remove support for some of the patterns deprecated nine months ago in React 0.14. We...
Read more >Introducing Hooks
100% backwards-compatible. Hooks don't contain any breaking changes. Available now. Hooks are now available with the release of v16.8.0. There are no ...
Read more >React v16.0 – React Blog
React 16 includes a number of small breaking changes. These only affect uncommon use cases and we don't expect them to break most...
Read more >Versioning Policy
Breaking changes are inconvenient for everyone, so we try to minimize the number of major releases – for example, React 15 was released...
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
Should be fixed in this PR: https://github.com/storybooks/storybook/pull/6475
This issue seems like it hasn’t gotten much action lately. Closing, please shout if you’re still stuck on this!