Storybook 5.3 failing to install on node 8

Describe the bug Due to inquirer dropping support for node 8 in a minor version (7.3.0), it’s no longer possible to install @storybook/react@5.3.x in node 8.

To Reproduce Steps to reproduce the behavior:

1. nvm use 8
2. yarn add --dev @storybook/react@5.3
3. error chalk@4.1.0: The engine "node" is incompatible with this module. Expected version ">=10". Got "8.17.0"

Expected behavior It should install without error

Additional context I traced this down to https://github.com/SBoudrias/Inquirer.js/issues/940. One workaround that storybook could do is to release a 5.3 patch using inquirer@7.2.0 instead of relying on semver and ^7.0.0. For now, I’ve been able to work around this using resolutions in my package.json, but that’s not ideal. Hopefully inquirer will release a fix, but I wanted to at least raise this issue here because that’s where I ran into it and others might too.

[IanVS]

Hi @shilman, yes I understand that Node 8 is out of support. But some people like me are forced to still use it because of complicated reasons. I think it is a project’s responsibility to bump their major version any time a “breaking” change is made, and that dropping support for an execution environment is a breaking change. It definitely broke my usage.

I’m not asking that storybook continue to support old node versions, just that you are clear about which versions of storybook support which versions of node. @ndelangen suggested I downgrade to an old version of storybook. But I cannot tell which version I would need to downgrade to. And no matter what, your engines in package.json should be updated to reflect your current level of support.

And ideally, a simple change to lock storybook 5.x to inquirer 7.2 would restore node 8 compatibility, allowing you to say that 5.x will at least probably work in node 8 (even if it’s not totally tested), and 6.x is node 10+. Would you consider a PR that makes these changes?

[stale[bot]]

Hi everyone! Seems like there hasn’t been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don’t have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!