Storybook 6.3 stopped respecting some custom reactDocgenTypescriptOptions

Hello.

I’ve discovered that after updating from 6.2.9 to 6.3.0.

Describe the bug Specifing custom values for some docgen options (according to the docs) isn’t working any more. E.g. setDisplayName: false has no effect.

To Reproduce Sorry, I don’t know how to reproduce it outside of my project. But you can see in the storybook’s code that some values are hardcoded now. Changing these lines fixes my issue.

System

  System:
    OS: Linux 4.19 Ubuntu 20.04.1 LTS (Focal Fossa)
    CPU: (8) x64 Intel(R) Core(TM) i7-8550U CPU @ 1.80GHz
  Binaries:
    Node: 14.15.3 - ~/.config/nvm/14.15.3/bin/node
    Yarn: 1.22.4 - /mnt/c/Program Files (x86)/Yarn/bin/yarn
    npm: 6.14.9 - ~/.config/nvm/14.15.3/bin/npm

Additional context The bug has two levels: these hardcoded values and another bug with custom options in react-docgen-typescript-plugin@1.0.0. Since 6.3 uses the fork @storybook/react-docgen-typescript-plugin, it has to address both of them.

BTW, can’t find the source of @storybook/react-docgen-typescript-plugin to send a PR.

[shilman]

@zhzz Nice! I don’t know when that will be released, but when it is we’ll upgrade our dependency. Thanks!!!

[zhzz]

@shilman have already done! https://github.com/hipstersmoothie/react-docgen-typescript-plugin/pull/49