Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Storyshots ships *.ts files in dist/ directory

See original GitHub issue

Describe the bug

The current (beta.37 and beta.38) Storyshots package contains TypeScript files along with transpiled files in dist/. This causes jest to (try to) import the wrong file.

To Reproduce

git clone https://github.com/bard/repro-storyshots-dist-ts
cd repro-storyshots-dist-ts
yarn
yarn jest storyshots.test.ts

    /tmp/project/node_modules/@storybook/addon-storyshots/dist/frameworks/frameworkLoader.ts:2
    import fs from 'fs';
    ^^^^^^

    SyntaxError: Cannot use import statement outside a module

    > 1 | import initStoryshots from '@storybook/addon-storyshots';
        | ^
      2 | 
      3 | initStoryshots()
      4 |

Expected behavior

Storyshots gets imported without error.

System:

Environment Info:

  System:
    OS: Linux 5.7 Arch Linux
    CPU: (4) x64 Intel(R) Core(TM) i5-7200U CPU @ 2.50GHz
  Binaries:
    Node: 14.4.0 - /usr/sbin/node
    Yarn: 1.22.4 - /usr/sbin/yarn
    npm: 6.14.5 - /usr/sbin/npm
  Browsers:
    Firefox: 77.0.1
  npmPackages:
    @storybook/addon-storyshots: 6.0.0-beta.38 => 6.0.0-beta.38

Issue Analytics

State:
Created 3 years ago
Reactions:2
Comments:17 (10 by maintainers)

Top GitHub Comments

3reactions

floArcommented, Aug 4, 2020

Digging deeper, I found the actual error: In cd61e43e8ba71821caf089e3efb2a688003e31e4 there is a change to exclude framework folder from cleanup for the cli in the prepare script. This seems to have the side-effect on the framework folder withing storyshots. I will see if I can muster the regex knowledge to fix this 😃

2reactions

shilmancommented, Aug 4, 2020

Awesome detective work @floAr. Hero! 🥇

cc @tooppaaa