question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Support for aXe / Puppeteer / storyshot / CI / Jest flow?

See original GitHub issue

Is your feature request related to a problem? Please describe. No. Other than, trying to make the world a little more accessible! 😉

Describe the solution you’d like I’ve got code working with Storyshots, but the addon-a11y mentions CI integration in its roadmap and add-ons seem more focused on the Storybook UI and not on test suites. Storyshots seems to be focused on DOM and image snapshots–that is it has artifacts that are stored in git and diff’ed.

The workflow working today is Storybook build CLI -> Jest -> Storyshots -> Puppeteer -> Jest expect() -> AxePuppeteer -> aXe. Performance is more than twice (3 min vs 8 min) that of StoryShots + jest-axe which uses jsDOM on the 448 stories I’m testing in Salesforce Lightning Design System for React.

Describe alternatives you’ve considered I’ve implemented jest-axe with Storybook, but it’s too slow for the large scope of our project of implementing https://www.lightningdesignsystem.com/ .

Are you able to assist bring the feature to reality? Yes, I’d love to contribute after corporate approval. That’s primarily why I’m asking for some direction. Where would this feature live? I’m guessing it would be it’s own add-on like addon-storyshots-puppeteer or be added into that add-on and linked to from the addon-a11y. addon-storyshots-puppeteer is a vague name. It describes the how and not the what it does. On a related note, is storyshots really story-ci in its purpose? My running code structure is very similar to addon-storyshots-puppeteer, it’s almost like it got copied and pasted or something. 😄

Additional context Screenshot: Unfortunately, the color contrast in the terminal isn’t very high in this screenshot. Screen Shot 2019-07-20 at 2 19 30 PM

Related links

Issue Analytics

  • State:open
  • Created 4 years ago
  • Reactions:2
  • Comments:8 (5 by maintainers)

github_iconTop GitHub Comments

3reactions
Hypnosphicommented, Aug 27, 2019

I think it can be actually a part of addon-storyshots-puppeteer, and use expect(page).toPassAxeTests() from jest-puppeteer-axe in test body instead of screenshot

0reactions
Hypnosphicommented, Nov 24, 2019

Implemented in #8934

Read more comments on GitHub >

github_iconTop Results From Across the Web

@wordpress/jest-puppeteer-axe - npm
Defines Jest async matcher to check whether a given Puppeteer's page instance passes Axe accessibility tests. Installation. Install the module. npm install @ ......
Read more >
@storybook/addon-storyshots-puppeteer - Package Manager
Fast, reliable, and secure dependency management.
Read more >
npm - Snyk
... babel-plugin-root-import · babel-plugin-source-map-support · babel-plugin-syntax-dynamic-import · babel-plugin-syntax-flow · babel-plugin-syntax-jsx ...
Read more >
wordpress/jest-puppeteer-axe | Block Editor Handbook
Axe (the Accessibility Engine) API integration with Jest and Puppeteer. Defines Jest async matcher to check whether a given Puppeteer's page…
Read more >
@storybook/addon-info: Versions | Openbase
Axe storyshots: move to original @wordpress/jest-puppeteer-axe package (#9337) ... Addon-docs: Improve basic support for Flow props (#8890) ...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found