Theme variables(brandTitle, brandUrl, brandImage) not working
See original GitHub issueDescribe the bug
Even if I set brandTitle, brandUrl, brandImage
on theme object, It doesn’t work at all(5.1.0-alpha.27)
To Reproduce
Set any combinations of brandTitle, brandUrl, brandImage
of defined, undefined, null
on theme object.
Expected behavior SidebarHeading should be rendered according to the inputs from options
System:
- OS: Windows10, Ubuntu 18.04
- Browser: chrome, firefox
- Framework: react
- Version: 5.1.0-alpha.27
Issue Analytics
- State:
- Created 4 years ago
- Reactions:2
- Comments:22 (20 by maintainers)
Top Results From Across the Web
Theme variables(brandTitle, brandUrl, brandImage) not ...
Describe the bug. Even if I set brandTitle, brandUrl, brandImage on theme object, It doesn't work at all(5.1.0-alpha.27). To Reproduce
Read more >Theming
This function includes shorthands for the most common theme variables. ... brandTitle: 'My custom storybook', brandUrl: 'https://example.com', brandImage: ...
Read more >Theming Storybook - Storybook for React Apps
The create function provides many theme variables that you can override. This means you can set the values for backgrounds, shadows, borders, etc....
Read more >Dynamic theming
This function includes shorthands for the most common theme variables. ... brandTitle: 'My custom storybook', brandUrl: 'https://example.com', brandImage: ...
Read more >storybook-facelift
Start using storybook-facelift in your project by running `npm i ... (typically all are apart from brandTitle , brandUrl & brandImage ).
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
It is this line
https://github.com/storybooks/storybook/blob/8c4ee76dab03402b6d5a89b08a2504939d6f23e4/lib/theming/src/create.ts#L175
this prevents the user from setting a
brandImage
@lonyele 화이팅! ㅋㅋㅋㅋ