Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Viewport Addon: Border-box modifies iframe size

See original GitHub issue

The border of #storybook-preview-iframe reduces the width and height of the document by 20px thanks to * { box-sizing: border-box; }.

This means that a viewport is not the size it says it is.

With the following viewport defined:

viewports: {
  bp1: {
    name: 'Breakpoint 1',
    styles: {
      width: '320px',
      height: '480px',
    },
  }
}

The iFrame document should be 320px by 460px, but instead it actually is 300px by 460px.

System:

OS: MacOS
Device: Macbook Pro 13" 2017
Browser: Chrome
Framework: react
Addons: @storybook/addon-viewport
Version: ^5.0.0

Issue Analytics

State:
Created 5 years ago
Reactions:3
Comments:6 (6 by maintainers)

Top GitHub Comments

3reactions

shilmancommented, Mar 11, 2019

Yo-ho-ho!! I just released https://github.com/storybooks/storybook/releases/tag/v5.1.0-alpha.4 containing PR #5993 that references this issue. Upgrade today to try it out!

Because it’s a pre-release you can find it on the @next NPM tag.

1reaction

shilmancommented, Mar 17, 2019

Whoopee!! I just released https://github.com/storybooks/storybook/releases/tag/v5.0.2 containing PR #5993 that references this issue. Upgrade today to try it out!