No audio from Youtube plugin. Scrubbing breaks stream

---

name: Packaged Windows streamlinkrc has unquoted paths about: Unquoted paths for ffmpeg-ffmpeg and rtmpdump parameters

Plugin Issue

• This is a plugin issue and I have read the contribution guidelines.

Description

When using a plugin for Youtube, there is no audio. Video displays but scrubbing breaks the stream.

OS: Windows 10 1909
Terminal: Windows Terminal 1.0.1811.0
Streamlink: 1.5.0
Player: VLC 3.0.11 x64

Here is the streamlinkrc file I used that reproduces the issue: https://gist.github.com/sorianov/b5c16b81934c358b1f9abfdeaf10790b Here is the streamlinkrc file where I no longer experience the issue: https://gist.github.com/sorianov/fce15dae10d408f914eb86071e97e13c

Reproduction steps / Explicit stream URLs to test

Tested using https://www.youtube.com/watch?v=InJS9Dhon04

1. Update from an old version of streamlink using streamlink-1.5.0.exe from 1.5.0 release.
2. Open Windows Terminal
3. Enter streamlink https://www.youtube.com/watch?v=InJS9Dhon04 best

Log output

https://gist.github.com/sorianov/8fc0201b1c21540274cd3d33c7991509

Additional comments, screenshots, etc.

Wrapping the ffmpeg-ffmpeg and rtmpdump config parameters in quotes fixed this issue for me. See working streamlinkrc gist. I am able to scrub and audio works with my player (VLC) with the working streamlinkrc.

[sorianov]

Sorry, I have added further detail to the main post. Please note that I have fixed the issue for myself, but I thought I would bring it up here. I am new to using streamlink and was playing around with it the other night and encountered this issue.

[bastimeyer]

https://github.com/streamlink/streamlink/blob/1.5.0/win32/streamlinkrc#L50 https://github.com/streamlink/streamlink/blob/1.5.0/win32/streamlinkrc#L56 This thread is about those two lines in the config file which gets written by the Streamlink installer for Windows. Other OSes don’t have a default config and config files need to be created by the user himself. As you can see though, both of these two lines are actually comments and not real config vars.

This is the regex of how config lines are parsed by the overwritten convert_arg_line_to_args argparse method: (?P<name>[A-z-]+)\s*(?P<op>=)?\s*(?P<value>.*) This means that values don’t need to be quoted.

This is what the config file syntax documentation says:

Any quotes used will be part of the value, so only use when the value needs them, e.g. specifying a player with a path containing spaces.

This is meant for values for the --player parameter for example, where you can set a quoted absolute player executable path with spaces in between and additional player parameters, as the entire value will get parsed with shell scripting syntax. This has nothing to do with the config parsing itself.

If you take a look at the command resolver implementation of the FFMPEGMuxer class, everything you put into the ffmpeg-ffmpeg config var (without quotes), will be used as a parameter for the which shell utility method, which resolves single executable names, or relative/absolute executable paths from the PATH environment variable. Quoting the entire value would therefore cause issues here.

Overall, this means that both lines in the default Windows config file are correct by not being quoted, if they were uncommented.