Hot-reloading not working

Hi, I think I’m hitting this again https://github.com/streamlit/streamlit/issues/358 I did not investigate why the fix https://github.com/streamlit/streamlit/pull/537 doesn’t work

System

Streamlit: version 0.51.0
Description:    Manjaro Linux
Release:        18.1.3

Using streamlit remotely with ssh port forwarding

Steps to reproduce:

Files

project/demo/demo.py

import streamlit as st
from mytest import fun

st.info(fun())

---

project/src/mytest.py

def fun():
    return 2

Execute

cd project
export PYTHONPATH="${PYTHONPATH}:src/"
streamlit run demo/demo.py

Problem

Changing the return value of fun() in src/mytest.py doesn’t change the output in streamlit.

Neither by modifying src/mytest.py and saving it (this would be cool), modifying demo/demo.py and saving it, pressing Run again nor Clear cache

Workaround

Closing and restart the streamlit server.

Maybe related

I have problems making streamlit recognize newly installed python packages, I have to restart the server.

[monchier]

Would it work if we had nested python packages, e.g. src/mypackage/mytest.py, but only src in the PYTHONPATH?

We will allow anything prefixed by an element in the PYTHONPATH, so it should work. I think we should consider that the individual paths specified in the PYTHONPATH can be absolute paths or paths that are relative to the current working directory.

Please consider adding to the watcher all the python files *.py recursively from the working directory from which streamlit is launched.

This was debated some time back and we decided against it. We choose instead to include everything that was contained in the directory of the main python script. The reasoning behind that is that you have less control on what it is in your current working directory. That said, I’ll bring it up again internally. We can also add more configurability. The PYTHONPATH itself allows for easily get around this and seems a reasonable solution to me. Given that the PYTHONPATH can be relative, by adding . to the PYTHONPATH you would allow anything contained in the current working directory recursively.

[lucmos]

Hi,

Would it work if we had nested python packages, e.g. src/mypackage/mytest.py, but only src in the PYTHONPATH?

Please consider adding to the watcher all the python files *.py recursively from the working directory from which streamlit is launched. So in in this examples I’d like to watch all the file that match project/**/*.py.

As an additional benefit, in this way it should work even with configurations that don’t make use of the PYTHONPATH env variable, but use the os package to change paths.