GameBase.MinimizedMinimumUpateRate & ThreadThrottler appare to have issues/ Can't enforce minimum update rate on minimized games.
See original GitHub issueRelease Type: Official Release
Version: 3.0
Platform(s): Windows
Describe the bug When setting MinimizedMinimumUpdateRate and/or changing the throttle type to any option Standard, PreciseAuto or PreciseManual the game appears to sleep indefinitely when minimized. The throttle does not appear to be effective in enforcing a minimum rate. This is an issue for locally hosted multiplayer games when the server is minimized, as well as headless implementations when the server was minimized.
To Reproduce Steps to reproduce the behavior:
- Create a game
- Try to modify ((GameBase)Game).MinimizedMinimumUpdateRate
- Optionally change the type using the set methods.
- Minimize the window
Note: You will likely need to put something into the game so that you are aware of game rate when minimized.
Expected behavior I would expect setting the MinimizedMinimumUpdateRate would throttle or rate limit the game to enforce a minimum rate, in this case I don’t want any limit. I’d request an option be added to the Throttler for Disabled and a SetDisabled() method be added. Optionally this could be added to GameBase to prevent the throttle from ever being checked in the if statement for if Minimized check.
Screenshots If applicable, add screenshots to help explain your problem (use GitHub drag & drop)
Log and callstacks
If any, please attach here any log or callstack (preferably in a .txt
file using GitHub drag and drop)
Additional context I looked into the source and I’m not sure I’m seeing what I’m actually running locally; one type appears to not call the method in the throttler (SetToPreciseAuto). Also, I don’t have the time at the moment to debug the sleep logic.
Issue Analytics
- State:
- Created 5 years ago
- Comments:9 (5 by maintainers)
Top GitHub Comments
should be a 5 minute action for @Eideren 😃
I still wasn’t able to reproduce this issue but hopefully clearing up the doc might alleviate one of the other issues you brought up.
If someone else stumbles onto this issue please provide a repro with your issue.