Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

External/full links should bypass react-router-component

See original GitHub issue

In order to integrate with legacy sites, we need react router to hijack the links or send the user to a hardcoded url. It’d be nice for react-router-component to simply pass through requests for full links.

React.createElement(Link, {
    href: 'http://example.com/page1',
}, 'Click here')

Currently, if you try to do an external link through react-router-component, as shown above you’ll end up navigating to something like http://mydomain:3000/example.com/page1 which will in most cases hit the react-router-component NotFound page.

Because ‘http://example.com/page1’ is a full link, it should escape the react-router component and do a normal browser request.

Issue Analytics

State:
Created 9 years ago
Reactions:1
Comments:9 (5 by maintainers)

Top GitHub Comments

1reaction

ftorre104commented, Jan 12, 2015

Apparently

React.createElement(Link, {
    className: 'sitemap-link',
    href: 'http://example.com/profile',
    rel: 'external'
}, 'See your profile')

Is being translated into:

<a class="sitemap-link" href="http:/example.com/profile" rel="external" data-reactid=".2f156eg3aio.1.0.0.0.1.4">See your profile</a>

However, I tried updating the html on the fly to a syntactically correct full link http://example.com. https://www.dropbox.com/s/z712upmm4eihuxh/Screenshot 2015-01-12 10.55.46.png?dl=0 But react-router-component still grabs it on click and makes it relative: http://localhost:3000/example.com/profile

0reactions

STRMLcommented, Feb 26, 2015

Published as 0.24.0.