question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

createBroadcast implementation causes performance issues

See original GitHub issue

this lines

return () => {
    listeners = listeners.filter(item => item !== listener)
 }

produce a lot of new objects which leads to a frequent garbage collections, which take sometimes up to 250 ms.

this can be probably avoided by changing listeners from array to a simple hash object like { [id]: listner }, and the lines above to

return () => {
    delete listeners[id]
 }

Issue Analytics

  • State:closed
  • Created 6 years ago
  • Comments:13 (8 by maintainers)

github_iconTop GitHub Comments

1reaction
vesparnycommented, Jun 28, 2017

I have published a new version of brcast that addresses this issue. Feel free to steal the code from there while you wait to switch to theming

1reaction
kittencommented, Jun 20, 2017

We should probably just switch to iamstarkov/theming soon.

But it depends on brcast which uses the same filtering logic unfortunately: https://github.com/vesparny/brcast/blob/master/index.js#L16

Read more comments on GitHub >

github_iconTop Results From Across the Web

Create a broadcast domain - Product documentation
Broadcast domains group network ports in the cluster that belong to the same layer 2 network.
Read more >
Optimizing Spark Streaming applications reading data ... - Stratio
Activating the checkpointing during the creation of the Spark context can cause performance problems. · Making our own implementation keeping the ...
Read more >
Performance Optimization tips for Node.js Applications
This article covers performance optimization techniques, tools, and tips to make high-performing Node.js apps.
Read more >
Issue WITH-OPEN-FILE-SETQ Writeup - CLHS
Related issues: WITH-OPEN-FILE-STREAM-EXTENT ... Common Lisp all implement WITH-OPEN-FILE in such a way that the ... problems. Performance impact:.
Read more >
AbstractAmazonKinesis (AWS SDK for Java - 1.12.363)
Simplified method form for invoking the CreateStream operation. ... typically used for debugging issues where a service isn't acting as expected.
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found