Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

flowtyped props, how?

See original GitHub issue

Is this right?

/* @flow */
import React from 'react';
import styled from 'styled-components';

type Props = {
  bold?: bool,
};

const Text = styled.span`
  color: ${props => props.theme.colors.black};
  font-family: ${props => props.theme.fontFamily};
  font-size: ${props => props.theme.fontSize.text};
  font-weight: ${props => props.bold ? props.theme.fontWeight : 'normal'};
  line-height: ${props => props.theme.lineHeight};
`;

export default (props: Props) => <Text {...props} />;

Issue Analytics

State:
Created 7 years ago
Reactions:2
Comments:5 (3 by maintainers)

Top GitHub Comments

5reactions

mxstbrcommented, Nov 23, 2016

That LGTM, I wonder if flow understands propTypes? /cc @ryyppy @relekang

const Text = styled.span`
  color: ${props => props.theme.colors.black};
  font-family: ${props => props.theme.fontFamily};
  font-size: ${props => props.theme.fontSize.text};
  font-weight: ${props => props.bold ? props.theme.fontWeight : 'normal'};
  line-height: ${props => props.theme.lineHeight};
`;

Text.propTypes = {
  bold: React.PropTypes.bool,
}

0reactions

dbertellacommented, Jan 12, 2017

@steida your solution seems working fine, I’m wondering, do you know why you have to wrap the styled-component in a functional one to make it working with flow?