Integrate Danger

Danger is a bot that let’s you write rules that are used to automatically check each PR for common problems. (like “you forgot to add a changelog entry”)

It’s written in Ruby (a JS port is being worked on, though it’s not ready yet), and I haven’t done Ruby in a while, so I’d love if somebody from the community could help out with this!

I might have to do some setup for the repo or a bot, but I’m sure we can figure that out as we go along in a PR.

---

Some of the rules I imagine would be useful for this repo:

• Enforce CHANGELOG.md entries for each PR that touches .js files
• A change was made in StyledComponent.js that wasn’t made in StyledNativeComponent.js – warn that this might have to be done
• Warn that changes to ThemeProvider.js, StyledComponent.js or StyledNativeComponent.js might be semver major changes if they touch the context stuff
• Don’t let testing shortcuts be merged into master (fit, fdescribe, it.only, describe.only)
• Enforce rebases to remove “Merge master into bla” commits?
• Enforce that a test must be added for the changes? (not sure if this makes sense for everything, maybe enforce for all .js files in the src/ folder except for src/vendor)
• Enforce a certain commit style? Not sure if this is really necessary.
• Anything else you can come up with that might be an issue with PRs more often than not!

[mxstbr]

Done by the amazing @nickgnd in #121! 🎉

[nickgnd]

@mxstbr wow, thanks! Let me know if you need further help to adjust Danger’s rules or in other on ruby stuff 🤓 💎