Prettier pre-commit hook

Now that we’re using prettier to keep our formatting consistent, is there interest in a pre-commit hook to ensure all commits are Prettified? I’ve had great success with this in my day job, but I’m not sure how common this is on large open-source projects.

If this is something we want, which direction would we want to go in? There are a few options on the Prettier docs. I’ve always used the lint-staged with husky solution, but I’d like to hear thoughts on this.

I’m happy to pick this up myself if we want it implemented.

[mxstbr]

Yes yes yes yes! Let’s go lint-staged with husky.

[kitten]

@lukebelliveau

I’m also having some issues between prettier and the flow-typed definitions:

I do not think we should run either prettier or eslint on the flow-typed/ folder

will check for conformance to prettier rules, eslint --fix will not do formatting nearly as well as running yarn prettier on the code - so it’s a bit different than actually running prettier.

I’ve left comments on your PR; actually the opposite will lead to problems. The plugin runs prettier after all other rules and the configs disable conflicting rules. so it actually works better together using the config + plugin