question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

[v2] ThemeProvider is broken on IE <= 10

See original GitHub issue

Version

2.0.0-17

Reproduction

import React from 'react';
import styled from 'styled-components';

const Title = styled.h1`
  font-size: 2em;
  color: ${props => props.theme.color || '#e2e2e2'};
`;

Expected Behavior

The Title component should have the color passed in the ThemeProvider.

Actual Behavior

The default value is being applied since the theme object is empty.

This works on 1.4.6. Maybe the fix on PR #379 (issue #355) is not applied on v2?

Issue Analytics

  • State:closed
  • Created 6 years ago
  • Reactions:2
  • Comments:9 (6 by maintainers)

github_iconTop GitHub Comments

1reaction
kittencommented, May 24, 2017

@anton6 It is already as v2.0.0-19 or under @rc tag. The official release of v2 will be very soon

1reaction
kittencommented, May 22, 2017

Seemed simple enough. This should fix it https://github.com/styled-components/styled-components/pull/807

I’m not even sure if we should support IE <= 10, but if it comes in such a “cheap package” it’s ok I guess.

Read more comments on GitHub >

github_iconTop Results From Across the Web

How to reinstall or repair Internet Explorer in Windows
Discusses how to repair or reinstall Internet Explorer in Windows.
Read more >
Migrating to v5: getting started - Material UI - MUI
This guide explains how and why to migrate from Material UI v4 to v5.
Read more >
Troubleshooting | React Navigation
Troubleshooting. This section attempts to outline issues that users frequently encounter when first getting accustomed to using React Navigation.
Read more >
Forcing IE 11 to behave as IE 10 - Stack Overflow
5. Why not just fix the bug? (or at least check what version the user is using) · 2. Since IE11 is still...
Read more >
8 Most Common Internet Explorer Issues (And Easy Ways to ...
2. Basic Internet Explorer Troubleshooting: Updates Not Installed. IE 11 About Page ... Internet Explorer comes with Windows 10 by default.
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found