Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

support nextjs <style> tag attributes in highlighting

See original GitHub issue

this extension works great for nextjs <style jsx> tag, but breaks for global styles: file

Could you add support for this?

Issue Analytics

State:
Created 2 years ago
Comments:23 (12 by maintainers)

Top GitHub Comments

1reaction

Pika-Poolcommented, Dec 17, 2021

This was my first merged PR. Thanks you so much for ur help @jasonwilliams. Really enjoyed contributing. Will try and contribute more in future

1reaction

Pika-Poolcommented, Dec 16, 2021

Yes, I’m still looking into it. Just stuck with some work.

that’s easily fixed by changing the asterisk to a plus. Good spot

It still has the same issue. It’ll be a match if only a global attribute is added. I came up with this final solution: https://regex101.com/r/17PV9d/1/ . It works on vscode too. screenshot:

I believe the engine used in find and the one used for syntax highlighting are 2 different engines. Find is ripgrep, syntax highlighting is https://github.com/kkos/oniguruma

I actually tried my previous solution with https://github.com/atom/node-oniguruma, a node module for oniguruma. It actually gives 2 captures, even if I use a non-capturing group (?:). I don’t understand how to omit/define the first group in the beginCaptures.

Anyway, for now, I guess the above solution works. I’ll put a PR for that.