Rule Improvement for maps - dollar-variable-colon-newline-after

Currently enabling dollar-variable-colon-newline-after errors for:

$map: (
  foo: value,
  bar: value,
);

Though it’s nice and readable.

To fix it I’m forced to write:

$map: 
  (
    foo: value,
    bar: value,
  );

[levacic]

This fix works great, but I’ve now discovered another use-case which I haven’t noticed before - function calls. I would like the following to be valid:

$foo: someFunction(
  bar: baz,
  qux: quux
);

It’s a multi-line variable declaration, and isn’t a map (which this issue is about), but it’s a similar situation in spirit - moving the function call to the next line seems like it would decrease readability, rather than increase it.

What do you think about this? I see how these exceptions are only making the rule more complicated, but maybe an alternate approach would make sense, ie. whitelisting what the rule is about - personally, I (think I) only care about this rule when using lists as the variable value.

[kristerkari]

What do you think about this? I see how these exceptions are only making the rule more complicated, but maybe an alternate approach would make sense, ie. whitelisting what the rule is about - personally, I (think I) only care about this rule when using lists as the variable value.

Hmm… yeah it seem that we would need more exceptions to the rule, maybe we should start thinking of putting the exceptions behind an option.