Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

BUG With : Merge pull request #3113 from gioboa/bugfix/#3112

See original GitHub issue

Description of your Issue or Request:

I just installed the last summnote version 0.8.12 and what a surprise when I use my customs buttons that use range selection.

I have a button that change “case”. It doesn’t work anymore because of the merge #3113

steps to reproduce (Add more if necessary):

In my custom button :

click: function () {
      var rangeSelection = $('#' + $('#localActiveId').val()).summernote('createRange');
      console.log(rangeSelection)
      var searchSelection = rangeSelection.toString();
      console.log(searchSelection);
      if(typeof searchSelection !== 'undefined' && searchSelection.trim() != "") {
        //-- si première lettre minuscule : majuscule
        if(searchSelection.trim()[0].toLowerCase() == searchSelection.trim()[0]) {
          searchSelection = searchSelection.toUpperCase();
        }
        else{
          searchSelection = searchSelection.toLowerCase();
        }
        context.invoke("editor.insertText", searchSelection);
      }
    }

searchSelection is cutted… It missed some text. With the version 0.8.11 it works perfectly then I searched a little.

In the merge pull I see this : w3cRange.setEnd(this.ec, this.sc.data ? Math.min(this.eo, this.sc.data.length) : this.eo); This doesn’t work on long text (more than one node !)

I think It must be : w3cRange.setEnd(this.ec, this.ec.data ? Math.min(this.eo, this.ec.data.length) : this.eo); (or w3cRange.setEnd(this.ec, this.sc.data ? Math.max(this.eo, this.sc.data.length) : this.eo);)