Bug when using custom serializers

Running Djoser 1.3.0 on Django 2.1.1

I can successfully create and use one custom serializer like so:

# users/serializers.py
class CustomUserCreateSerializer(UserCreateSerializer):
    class Meta:
        fields = tuple(User.REQUIRED_FIELDS) + (
            User.USERNAME_FIELD, User._meta.pk.name, 'password',
            'is_manager',
        )

# settings.py
DJOSER = {
    'SERIALIZERS': {
        'user_create': 'users.serializers.CustomUserCreateSerializer',
    },
}

But as soon as I create a second serializer I get an error:

# users/serializers.py
class CustomUserCreateSerializer(UserCreateSerializer):
    class Meta:
        fields = tuple(User.REQUIRED_FIELDS) + (
            User.USERNAME_FIELD, User._meta.pk.name, 'password',
            'is_manager',
        )

class CustomUserSerializer(UserSerializer):
    class Meta:
        model = User
        fields = tuple(User.REQUIRED_FIELDS) + (
            User._meta.pk.name,
            User.USERNAME_FIELD,
            'is_manager',
        )
        read_only_fields = (User.USERNAME_FIELD,)

# settings.py
DJOSER = {
    'SERIALIZERS': {
        'user_create': 'users.serializers.CustomUserCreateSerializer',
        'user': 'users.serializers.CustomUserSerializer',
    },
}

I receive this error: ImportError: Module "users.serializers" does not define a "UserSerializer" attribute/class.

The traceback leads me back to class CurrentUserSerializer(settings.SERIALIZERS.user): in djoser/serializers.py. If I remove that CurrentUserSerializer class, or if I change its inherited class to serializers.ModelSerializer then everything runs as expected.

My guess is that this is a sort of circular dependency issue with the new CurrentUserSerializer, but I’m not quite sure how to solve it in my code (or if that’s possible).

[jpdlor]

Same problem. But found a workaround by putting the CustomUserSerializer class in another file than the CustomUserCreateSerializer class and thus having 2 different imports from the SERIALIZERS setting. However it is ugly…

The djoser/serializers.py code class CurrentUserSerializer(settings.SERIALIZERS.user): is definitively the culprit, yes, (it creates a circular relationship). As a matter of fact I don’t understand why this CurrentUserSerializer class is here since it just for a deprecation warning which itself is triggered by the totally legit route /auth/users/me…

[nils-wisiol]

We fixed it for us by having CurrentUserSerializer inherit from djoser’s UserSerializer instead of the settings string. (This was also the case in Djoser before the deprication warning was introduced.)

Thanks for handling this so quickly, @joshua-s