PasswordResetView proposal to move the User.is_active check from database to Python

Something like this:

class PasswordResetView(utils.ActionViewMixin, generics.GenericAPIView):
    def get_users(self, email):
        if self._users is None:
            active_users = User._default_manager.filter(
                email__iexact=email,
                # is_active=True, <--- v0.6 code
            )
            # self._users = [u for u in active_users if u.has_usable_password()] <--- v0.6 code
            self._users = [u for u in active_users if u.is_active and u.has_usable_password()]
        return self._users

Here are the reasons:

1. If is_active is not True, then this opportunity can be used to notify the user that they’ve already registered an account with that email address, and [offer to] resend the activation email.

_users = User._default_manager.filter(email=email)
self._users = []
for u in _users:
    if u.has_usable_password():
        if u.is_active:
            self._users.append(u)
        else:
            # TODO resend activation email

1. I think with the v0.6 code, there will be some conflict if is_active is implemented in a model like this:

class User(AbstractBaseUser):
    score = models.SmallIntegerField(default=0)
    status = models.SmallIntegerField(default=0)
    email = models.CIEmailField(unique=True)
    name = models.CITextField()
    ip = models.ArrayField(models.GenericIPAddressField(unpack_ipv4=True))

    objects = UserManager()

    USERNAME_FIELD = 'email'

    @property
    def is_active(self):
        # FIXME can't do this, djoser uses .filter(is_active=True)
        return self.status > 0

    @is_active.setter
    def is_active(self, value):
        if value is True:
            self.status = abs(self.status or 1)
        elif value is False:
            self.status = -abs(self.status or 0)
        else:
            self.status = value

1. Any concerns about performance/inefficiency of retrieving unnecessary rows from the database should be nominal in real-world usage because there wouldn’t be very many unactive accounts tied to a single email address in most cases. And again, if the activation email resend is implemented, then the retrieval of these rows wouldn’t be considered wasted.

[pszpetkowski]

Same here, in case of any doubts do not hesitate to start a new issue and again - thank you for reporting and working on the issue.

[davidtgq]

Yes, this can be closed. Thank you for the great feedback, it’s been a pleasure 😃