Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Broken browser back button behavior

See original GitHub issue

Store updates from history.listen break browser back behavior, causing user to ping-pong between 2 routes.

Steps to reproduce:

User visits /home ->/hello -> /counter
On /counter, clicks browser back and lands on /hello
On /hello clicks browser back

Expected behavior: lands on /home Actual behavior: lands on /counter

GIF Illustration: ping pong

Branch that reproduces issue is available here: https://github.com/kswin/connected-react-router/tree/poc/broken-browser-back

Issue Analytics

State:
Created 5 years ago
Reactions:10
Comments:6

Top GitHub Comments

3reactions

roryp2commented, May 7, 2019

Is this going to be fixed? still an issue, even without time travel

0reactions

kswincommented, Jul 24, 2019

Well, I did fork this project and made time travel optional. That was the bit of code that caused the bug -> https://github.com/kswin/connected-react-router

// in package.json
 "connected-react-router": "github:kswin/connected-react-router"

// from your routes file
<ConnectedRouter history={reactHistory} hasTimeTravel={false}>

For the exact code change to the source see src/ConnectedRouter.js in PR https://github.com/kswin/connected-react-router/pull/3/files

It’s a long PR, but that’s because most files are just the distribution