Overrides do not work onload if 'preset' is set

When a preset has been defined, e.g. preset: starry; then the preset values are not correctly overridden e.g. 'preset: starry; grid: none;' will not remove the grid. Custom values are lost during update function when you use this.presets[this.data.preset].

I have made a temporary fix, which you may want to improve:

if (oldData.preset === undefined || oldData.preset !== this.data.preset) {
      var newData = Object.assign({}, this.presets[this.data.preset]);
      Object.assign(newData, this.el.components.environment.attrValue);
      this.el.setAttribute('environment', newData);
      return;
    }

UPDATE: My fix doesn’t actually quite work, due to all the if (data.property != oldData.property) code. So not quite sure of optimal way to fix this.

[tbalouet]

Just had the same problem. I’ve been silly hacking it with some

setTimeout(function(){
  document.querySelector("#sceneEnv").setAttribute("environment", "lightPosition", "0 5 10");
}, 1000);

Otherwise having <a-entity id="sceneEnv" environment="preset:forest;lightPosition=0 5 -10;"></a-entity> doesn’t work by itself.

Interested if you get to fix it! (great component btw!)

[vesper8]

I tried many ways of removing the fog from the presets. I successfully remove it but it still causes the conflict with particles, even though it’s clearly removed using setAttribute. It’s visually gone and I can also see that it’s gone from the element inside the debugger, yet it still causes issues. I had to revert to manually changing the hardcoded values inside the presets from this distribution file.