Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Sun-sky needs tweak to work with modern aframe

See original GitHub issue

Old style animation
Using componentchanged for rotation, which the docs now advise against
also, maybe add sun-position-setter to the component itself?
using getComputedAttribute instead of getAttribute (I assume the former is a deprecated version of the latter)
I don’t know what all is wrong with the actual dist file, this is stuff noticed in the part I had to copy/paste out f the demo, in sun-position-setter. I guess the actual sun-sky itself component is likewise broken.
No logs, things just don’t work when trying to use this with modern aframe. Which is a shame, because it’s pretty cool.

Issue Analytics

State:
Created 3 years ago
Comments:5

Top GitHub Comments

1reaction

Dante83commented, Jul 30, 2021

Great job 😄.

1reaction

kylebakeriocommented, Jul 28, 2021

Just wanted to share that I got this working with up to A-Frame 1.2.0 after all and added my own component to enable rotation as shown in the demo here, as well as to integrate showing stars at night (currently stars only work to aframe 1.1.0), and some faux-shadows with ‘fog’, in case anyone goes through th effort of digging through this.