(Intermediate) If running the docker image in foreground, sending a kill signal doesn't stop the container

To recreate the problem that exists today:

• run docker pull supertokens/supertokens-mysql:2.4
• Start the docker image in foreground: docker run -p 3567:3567 supertokens/supertokens-mysql:2.4
• Wait for it to start… It should display Started SuperTokens on 0.0.0.0:3567 with PID: <some PID>
• Now send the kill signal (Ctrl + C / Z on a Mac)

At this point, the Java process in the docker process should stop and the docker process itself should quit. However, that does not happen.

The docker file for the above image can be found in this repo. Please feel free to fork that as well.

As some extra info:

• if not using docker (manually installing it on your system), sending the kill signal does stop the running process.
• In the Java code (this repo), in Main.java, there is a function that registers a shutdown hook.

[Fabricio20]

Hey, answering your questions:

resulting CLI script has null instead of what’s in this file

I’ll look into it later today, it should automatically be shaded by gradle however.

The if [ -f /.dockerenv ]; then checks if the script is running in the docker container, however, I’m not sure if this is the recommended way of doing so.

According to this SO answer it seems like the preferred way would be to check cgroup since .dockerenv could be removed at any moment (read about .dockerinit).

If one runs the docker container in interactive mode, and then starts supertokens, it causes all sorts of problems.

What kind of issues are you experiencing? This should trap the sigs sent to bash and recreate them as a kill command for the child’s pid. (So even if starting manually this should have the same behaviour).

The Windows version of the script can remain exactly the same since the docker image is never going to be on Windows OS.

Windows script shouldn’t have been changed, just repackaged it on resources for the sake of consistency.

[rishabhpoddar]

Thank you @Fabricio20 . I’ll test with the docker image once again and let you know what happens 😃