[Solved, pending release]: Close java.sql.ResultSet objects used in the DB implementations

Currently ResultSet objects have not been closed in our DB implementations, they need to be closed to avoid memory leaks.

example :

public static KeyValueInfo getKeyValue(Start start, String key) throws SQLException, StorageQueryException {
    String QUERY = "SELECT value, created_at_time FROM " + Config.getConfig(start).getKeyValueTable()
            + " WHERE name = ?";

    try (Connection con = ConnectionPool.getConnection(start);
            PreparedStatement pst = con.prepareStatement(QUERY)) {
        pst.setString(1, key);
        ResultSet result = pst.executeQuery();
        if (result.next()) {
            return KeyValueInfoRowMapper.getInstance().mapOrThrow(result);
        }
    }
    return null;
}

Result set interface looks like this :

public interface ResultSet extends Wrapper, AutoCloseable

[rishabhpoddar]

Thanks @anugrahsinghal for resolving this issue.

I have added your profile to the contributor’s list in the core’s readme. Since these are refactor changes, they will be released in the next change to the core. Keeping this issue open until then.

[anugrahsinghal]

Hey @rishabhpoddar Have made the changes to the PostgreSQL plugin. https://github.com/supertokens/supertokens-postgresql-plugin/pull/29